lalpulsar_MakeSFTDAG passes environmental variables to condor

Summary

lalpulsar_MakeSFTDAG creates dag files for condor submission that rely on the flag getenv=true and on certain environmental variables having been set. Depending on which arguments are passed to lalpulsar_MakeSFTDAG, it will send 1 to 3 environmental variables, which are no longer accessible under the latest condor version (10.7.1).

Steps to reproduce

There are three environmental variables used in MakeSFTDAG:

LSC_DATAFIND_PATH (path or filename for gw_data_find executable, e.g. /usr/bin/gw_data_find) LIGO_DATAFIND_SERVER (segment database URL, e.g., datafind.ldas.cit:80) MAKESFTS_PATH. (path or filename for SFT making executable, e.g., /usr/bin/lalpulsar_MakeSFTs)

The first and third can be forced to take on specific values by using the "-j" and "-J" arguments, but the server name has no corresponding argument and is sent to condor as an environmental variable to be queried (which no longer works).

MakeSFTDAG needs to be reworked. Specifically, none of the above environmental variables should be passed as such to condor, and I suggest eliminating their use altogether in MakeSFTDAG, with default values provided for each of the three if no arguments are specified. (Mandatory arguments are another approach, but would make the program less friendly to new users.)

Context/environment

ldas-pcdev1 and ldas-pcdev2 on the CIT cluster

(tagging @evan-goetz and @karl-wette)