lalpulsar_CFSv2: slight confusion with --dFreq for --gridType={8,9}
CFSv2 does some slight nonsense with the --dFreq
option when asked to run with gridTypes 8 or 9, because in those cases the spacing is actually computed internally. Unlike --df{1,2,3}dot
, it doesn't throw an error if --dFreq
is passed. Nothing bad happens, it is just silently ignored, but that can still potentially confuse new users. (We just noticed this with some test setups @maria-antonia.ferrer was doing.)
Template counting, as used internally and for --countTemplates
, consistently uses the actual internal grid spacing. But the one place where the useless --dFreq
currently leaks to user-facing output is under --outputTiming
. Actually, the NFreq
output there will be wrong for both gridtypes even if the user doesn't set a --dFreq
manually, because the 1/2Tspan default is used rather than the actual grid spacing. I'll fix that along with adding an explicit user option error.