lalsuite merge requestshttps://git.ligo.org/lscsoft/lalsuite/-/merge_requests2024-03-19T00:32:02Zhttps://git.ligo.org/lscsoft/lalsuite/-/merge_requests/2262LALPulsar: pretty-format more C code2024-03-19T00:32:02ZKarl WetteLALPulsar: pretty-format more C code### Description
Pretty-format all C code in LALPulsar _apart from_ the following files, where there is ongoing development:
```
bin/HoughFstat/HierarchicalSearch.c
bin/HoughFstat/HierarchicalSearch.h
bin/HoughFstat/LocalComputeFstatHoug...### Description
Pretty-format all C code in LALPulsar _apart from_ the following files, where there is ongoing development:
```
bin/HoughFstat/HierarchicalSearch.c
bin/HoughFstat/HierarchicalSearch.h
bin/HoughFstat/LocalComputeFstatHoughMap.c
lib/DriveHough.c
lib/HoughMap.c
lib/HoughMap.h
lib/LALHough.h
lib/PHMD.h
lib/Peak2PHMD.c
```
The above files are listed in a file `lalpulsar/.pretty.exclude` which is used to (temporarily) exclude files from pretty-formatting.
### API Changes and Justification
#### Backwards Compatible Changes
- [x] This change does not modify any class/function/struct/type definitions
in a public C header file or any Python class/function definitions
- [ ] This change adds new classes/functions/structs/types
to a public C header file or Python module
#### Backwards Incompatible Changes
- [ ] This change modifies an existing class/function/struct/type definition
in a public C header file or Python module
- [ ] This change removes an existing class/function/struct/type
from a public C header file or Python module
If any of the Backwards Incompatible check boxes are ticked please
provide a justification why this change is necessary and why it needs
to be done in a backwards incompatible way.
#### Review Status
Please provide details on any reviews related to this change and
and the associated reviewers.Karl WetteKarl Wettehttps://git.ligo.org/lscsoft/lalsuite/-/merge_requests/2260lalpulsar_CopyPublicSFTs.py: write a README.md describing the SFT file/direct...2024-03-19T00:34:12ZKarl Wettelalpulsar_CopyPublicSFTs.py: write a README.md describing the SFT file/directory naming scheme### Description
Modify `lalpulsar_CopyPublicSFTs` to write a `README.md` file describing the SFT file/directory naming scheme into the destination directory.
The SFT directory naming scheme generates top-level directories which are a ...### Description
Modify `lalpulsar_CopyPublicSFTs` to write a `README.md` file describing the SFT file/directory naming scheme into the destination directory.
The SFT directory naming scheme generates top-level directories which are a little hard to parse, e.g.:
```
H1_1800SFT_O4RUN+R1+CGDSCALIBSTRAINCLEANGATEDG01+WTKEY5_BROADBAND/...
```
The `README.md` is intended to fully describe the top-level naming scheme, and in addition how the SFTs are named and organised into subdirectories.
### API Changes and Justification
#### Backwards Compatible Changes
- [ ] This change does not modify any class/function/struct/type definitions
in a public C header file or any Python class/function definitions
- [x] This change adds new classes/functions/structs/types
to a public C header file or Python module
#### Backwards Incompatible Changes
- [ ] This change modifies an existing class/function/struct/type definition
in a public C header file or Python module
- [ ] This change removes an existing class/function/struct/type
from a public C header file or Python module
If any of the Backwards Incompatible check boxes are ticked please
provide a justification why this change is necessary and why it needs
to be done in a backwards incompatible way.
#### Review Status
cc @keith-riles @david-keitelKarl WetteKarl Wettehttps://git.ligo.org/lscsoft/lalsuite/-/merge_requests/2184Build for ABI compatibility with Numpy >= 1.192023-08-01T20:03:13ZLeo P. SingerBuild for ABI compatibility with Numpy >= 1.19### Description
As of Numpy 1.25, Numpy is backwards compatible back to Numpy 1.19.
See https://numpy.org/doc/stable/release/1.25.0-notes.html#compiling-against-the-numpy-c-api-is-now-backwards-compatible-by-default.
### API C...### Description
As of Numpy 1.25, Numpy is backwards compatible back to Numpy 1.19.
See https://numpy.org/doc/stable/release/1.25.0-notes.html#compiling-against-the-numpy-c-api-is-now-backwards-compatible-by-default.
### API Changes and Justification
#### Backwards Compatible Changes
* [x] This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
* [ ] This change adds new classes/functions/structs/types to a public C header file or Python module
#### Backwards Incompatible Changes
* [ ] This change modifies an existing class/function/struct/type definition in a public C header file or Python module
* [ ] This change removes an existing class/function/struct/type from a public C header file or Python module
If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.
#### Review Status
Please provide details on any reviews related to this change and and the associated reviewers.https://git.ligo.org/lscsoft/lalsuite/-/merge_requests/2105update lalframe for ldas-tools-framecppc 3.02024-01-08T17:42:32ZJolien Creightonupdate lalframe for ldas-tools-framecppc 3.0### Description
Detailed description of the changes, why they are being made, etc...
Also indicate appropriate tickets and tests that have been run to
determine that the changes work as intended and do not introduce
other problems.
###...### Description
Detailed description of the changes, why they are being made, etc...
Also indicate appropriate tickets and tests that have been run to
determine that the changes work as intended and do not introduce
other problems.
### API Changes and Justification
#### Backwards Compatible Changes
- [X] This change does not modify any class/function/struct/type definitions
in a public C header file or any Python class/function definitions
- [ ] This change adds new classes/functions/structs/types
to a public C header file or Python module
#### Backwards Incompatible Changes
- [ ] This change modifies an existing class/function/struct/type definition
in a public C header file or Python module
- [ ] This change removes an existing class/function/struct/type
from a public C header file or Python module
If any of the Backwards Incompatible check boxes are ticked please
provide a justification why this change is necessary and why it needs
to be done in a backwards incompatible way.
#### Review Status
Please provide details on any reviews related to this change and
and the associated reviewers.Duncan Macleodduncan.macleod@ligo.orgDuncan Macleodduncan.macleod@ligo.orghttps://git.ligo.org/lscsoft/lalsuite/-/merge_requests/2075fix matplotlib mathtext.fallback deprecation2023-02-24T14:32:16ZEthan Marxfix matplotlib mathtext.fallback deprecation### Description
Reopened version of #641 with template
`mathtext.fallback_to_cm = True` rcparam was deprecated in Matplotlib 3.3 in favor of `mathtext.fallback = "cm"`.
This currently effects the igwn-py39 environment (and likely other...### Description
Reopened version of #641 with template
`mathtext.fallback_to_cm = True` rcparam was deprecated in Matplotlib 3.3 in favor of `mathtext.fallback = "cm"`.
This currently effects the igwn-py39 environment (and likely others).
For example, running
```
conda activate igwn-py39
python
>>> from lalinference import bayespputils
KeyError: 'mathtext.fallback_to_cm is not a valid rc parameter (see rcParams.keys() for a list of valid parameters)'
```
I suspect this will require bumping matplotlib minimum version to 3.3, which seems like a large jump from the current 1.2.0
### API Changes and Justification
#### Backwards Compatible Changes
- [x] This change does not modify any class/function/struct/type definitions
in a public C header file or any Python class/function definitions
- [ ] This change adds new classes/functions/structs/types
to a public C header file or Python module
#### Backwards Incompatible Changes
- [ ] This change modifies an existing class/function/struct/type definition
in a public C header file or Python module
- [ ] This change removes an existing class/function/struct/type
from a public C header file or Python module
This change does not effect any API components#### Review Status
Please provide details on any reviews related to this change and
and the associated reviewers.https://git.ligo.org/lscsoft/lalsuite/-/merge_requests/2067Draft: Use Sphinx to render LALSuite documentation2023-04-17T15:43:34ZDuncan Macleodduncan.macleod@ligo.orgDraft: Use Sphinx to render LALSuite documentation### Description
This MR implements #618+.
### API Changes and Justification
#### Backwards Compatible Changes
- [x] This change does not modify any class/function/struct/type definitions
in a public C header file or any Python ...### Description
This MR implements #618+.
### API Changes and Justification
#### Backwards Compatible Changes
- [x] This change does not modify any class/function/struct/type definitions
in a public C header file or any Python class/function definitions
- [ ] This change adds new classes/functions/structs/types
to a public C header file or Python module
#### Backwards Incompatible Changes
- [ ] This change modifies an existing class/function/struct/type definition
in a public C header file or Python module
- [ ] This change removes an existing class/function/struct/type
from a public C header file or Python module
If any of the Backwards Incompatible check boxes are ticked please
provide a justification why this change is necessary and why it needs
to be done in a backwards incompatible way.
#### Review Status
Please provide details on any reviews related to this change and
and the associated reviewers.Duncan Macleodduncan.macleod@ligo.orgDuncan Macleodduncan.macleod@ligo.org