Skip to content

lalapps_PredictFstat user input checks and improvements

David Keitel requested to merge david-keitel/lalsuite:PFS-further-updates into master

Description

So far added two of the changes suggested in #376 (closed):

  1. check length of multiTimeStamps matches numDetectors to avoid segfault on inconsistent user input
  2. require assumeSqrtSX>0 if not NULL to avoid more esoteric error message from XLALComputeAntennaPatternSqrtDeterminant()

Pending feedback first: 3. make psi,Alpha,Delta inputs optional

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

For @karl-wette as usual.

Edited by David Keitel

Merge request reports