Add Rocky Linux 8 CI pipeline jobs

Description

This MR adds rockylinux 8 CI RPM build jobs.

API Changes and Justification

Backwards Compatible Changes

• This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
• This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

• This change modifies an existing class/function/struct/type definition in a public C header file or Python module
• This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

.gitlab-ci.yml

@@ -234,7 +234,6 @@ default:
   extends:
     - .rhel:rpm
     - .build-from-tarball
-  image: igwn/base:el7-testing
   variables:
     # disable repos we don't use
     DISABLE_REPOS: "htcondor osg"
@@ -269,7 +268,7 @@ default:
     - rpmbuild -ts --define "_topdir ${RPM_BUILD_TOPDIR}" ${TARBALL}
     - SRPM=${RPM_BUILD_TOPDIR}/SRPMS/${PACKAGE}-*.src.rpm
     # install build dependencies
-    - yum-builddep -y -q ${SRPM}
+    - yum-builddep -y ${SRPM}
     # print installed packages
     - yum list installed --quiet
     # build binary rpms and print details of what we got
@@ -326,6 +325,16 @@ default:
     - !reference [.ci-lalsuite-tag-build, rules]
     - !reference [.ci-docker, rules]
 
+.rpmbuild:el7:
+  extends:
+    - .rpmbuild
+  image: igwn/base:el7-testing
+
+.rpmbuild:el8:
+  extends:
+    - .rpmbuild
+  image: igwn/base:el8-testing
+
 # -- debian
 
 # template for debian packaging jobs
@@ -631,9 +640,14 @@ tarball:lal:
   needs:
     - tarball:lal
 
-lal:rpm:
+lal:rpm-el7:
   extends:
-     - .rpmbuild
+     - .rpmbuild:el7
+     - .lal
+
+lal:rpm-el8:
+  extends:
+     - .rpmbuild:el8
      - .lal
 
 lal:deb:
@@ -665,13 +679,21 @@ lal:conda:mkl:
 .lalframe:
   stage: LALFrame
 
-lalframe:rpm:
+lalframe:rpm-el7:
   extends:
-    - .rpmbuild
+    - .rpmbuild:el7
+    - .lalframe
+  needs:
+    - tarballs
+    - lal:rpm-el7
+
+lalframe:rpm-el8:
+  extends:
+    - .rpmbuild:el8
     - .lalframe
   needs:
     - tarballs
-    - lal:rpm
+    - lal:rpm-el8
 
 lalframe:deb:
   extends:
@@ -697,13 +719,21 @@ lalframe:conda:
 .lalmetaio:
   stage: LALMetaIO
 
-lalmetaio:rpm:
+lalmetaio:rpm-el7:
   extends:
-    - .rpmbuild
+    - .rpmbuild:el7
+    - .lalmetaio
+  needs:
+    - tarballs
+    - lal:rpm-el7
+
+lalmetaio:rpm-el8:
+  extends:
+    - .rpmbuild:el8
     - .lalmetaio
   needs:
     - tarballs
-    - lal:rpm
+    - lal:rpm-el8
 
 lalmetaio:deb:
   extends:
@@ -729,13 +759,21 @@ lalmetaio:conda:
 .lalsimulation:
   stage: LALSimulation
 
-lalsimulation:rpm:
+lalsimulation:rpm-el7:
   extends:
-    - .rpmbuild
+    - .rpmbuild:el7
     - .lalsimulation
   needs:
     - tarballs
-    - lal:rpm
+    - lal:rpm-el7
+
+lalsimulation:rpm-el8:
+  extends:
+    - .rpmbuild:el8
+    - .lalsimulation
+  needs:
+    - tarballs
+    - lal:rpm-el8
 
 lalsimulation:deb:
   extends:
@@ -763,15 +801,25 @@ lalsimulation:conda:
 .lalburst:
   stage: LALBurst
 
-lalburst:rpm:
+lalburst:rpm-el7:
   extends:
-    - .rpmbuild
+    - .rpmbuild:el7
+    - .lalburst
+  needs:
+    - tarballs
+    - lal:rpm-el7
+    - lalmetaio:rpm-el7
+    - lalsimulation:rpm-el7
+
+lalburst:rpm-el8:
+  extends:
+    - .rpmbuild:el8
     - .lalburst
   needs:
     - tarballs
-    - lal:rpm
-    - lalmetaio:rpm
-    - lalsimulation:rpm
+    - lal:rpm-el8
+    - lalmetaio:rpm-el8
+    - lalsimulation:rpm-el8
 
 lalburst:deb:
   extends:
@@ -801,17 +849,29 @@ lalburst:conda:
 .lalinspiral:
   stage: LALInspiral
 
-lalinspiral:rpm:
+lalinspiral:rpm-el7:
   extends:
-    - .rpmbuild
+    - .rpmbuild:el7
+    - .lalinspiral
+  needs:
+    - tarballs
+    - lal:rpm-el7
+    - lalframe:rpm-el7
+    - lalmetaio:rpm-el7
+    - lalsimulation:rpm-el7
+    - lalburst:rpm-el7
+
+lalinspiral:rpm-el8:
+  extends:
+    - .rpmbuild:el8
     - .lalinspiral
   needs:
     - tarballs
-    - lal:rpm
-    - lalframe:rpm
-    - lalmetaio:rpm
-    - lalsimulation:rpm
-    - lalburst:rpm
+    - lal:rpm-el8
+    - lalframe:rpm-el8
+    - lalmetaio:rpm-el8
+    - lalsimulation:rpm-el8
+    - lalburst:rpm-el8
 
 lalinspiral:deb:
   extends:
@@ -845,18 +905,31 @@ lalinspiral:conda:
 .lalinference:
   stage: LALInference
 
-lalinference:rpm:
+lalinference:rpm-el7:
   extends:
-    - .rpmbuild
+    - .rpmbuild:el7
+    - .lalinference
+  needs:
+    - tarballs
+    - lal:rpm-el7
+    - lalframe:rpm-el7
+    - lalmetaio:rpm-el7
+    - lalsimulation:rpm-el7
+    - lalburst:rpm-el7
+    - lalinspiral:rpm-el7
+
+lalinference:rpm-el8:
+  extends:
+    - .rpmbuild:el8
     - .lalinference
   needs:
     - tarballs
-    - lal:rpm
-    - lalframe:rpm
-    - lalmetaio:rpm
-    - lalsimulation:rpm
-    - lalburst:rpm
-    - lalinspiral:rpm
+    - lal:rpm-el8
+    - lalframe:rpm-el8
+    - lalmetaio:rpm-el8
+    - lalsimulation:rpm-el8
+    - lalburst:rpm-el8
+    - lalinspiral:rpm-el8
 
 lalinference:deb:
   extends:
@@ -892,19 +965,33 @@ lalinference:conda:
 .lalpulsar:
   stage: LALPulsar
 
-lalpulsar:rpm:
+lalpulsar:rpm-el7:
   extends:
-    - .rpmbuild
+    - .rpmbuild:el7
     - .lalpulsar
   needs:
     - tarballs
-    - lal:rpm
-    - lalframe:rpm
-    - lalmetaio:rpm
-    - lalsimulation:rpm
-    - lalburst:rpm
-    - lalinspiral:rpm
-    - lalinference:rpm
+    - lal:rpm-el7
+    - lalframe:rpm-el7
+    - lalmetaio:rpm-el7
+    - lalsimulation:rpm-el7
+    - lalburst:rpm-el7
+    - lalinspiral:rpm-el7
+    - lalinference:rpm-el7
+
+lalpulsar:rpm-el8:
+  extends:
+    - .rpmbuild:el8
+    - .lalpulsar
+  needs:
+    - tarballs
+    - lal:rpm-el8
+    - lalframe:rpm-el8
+    - lalmetaio:rpm-el8
+    - lalsimulation:rpm-el8
+    - lalburst:rpm-el8
+    - lalinspiral:rpm-el8
+    - lalinference:rpm-el8
 
 lalpulsar:deb:
   extends:
@@ -942,20 +1029,35 @@ lalpulsar:conda:
 .lalapps:
   stage: LALApps
 
-lalapps:rpm:
+lalapps:rpm-el7:
   extends:
-    - .rpmbuild
+    - .rpmbuild:el7
+    - .lalapps
+  needs:
+    - tarballs
+    - lal:rpm-el7
+    - lalframe:rpm-el7
+    - lalmetaio:rpm-el7
+    - lalsimulation:rpm-el7
+    - lalburst:rpm-el7
+    - lalinspiral:rpm-el7
+    - lalinference:rpm-el7
+    - lalpulsar:rpm-el7
+
+lalapps:rpm-el8:
+  extends:
+    - .rpmbuild:el8
     - .lalapps
   needs:
     - tarballs
-    - lal:rpm
-    - lalframe:rpm
-    - lalmetaio:rpm
-    - lalsimulation:rpm
-    - lalburst:rpm
-    - lalinspiral:rpm
-    - lalinference:rpm
-    - lalpulsar:rpm
+    - lal:rpm-el8
+    - lalframe:rpm-el8
+    - lalmetaio:rpm-el8
+    - lalsimulation:rpm-el8
+    - lalburst:rpm-el8
+    - lalinspiral:rpm-el8
+    - lalinference:rpm-el8
+    - lalpulsar:rpm-el8
 
 lalapps:deb:
   extends:
@@ -1241,7 +1343,7 @@ wheel:cp311-cp311-macos-arm64:
 .long-test-job:
   image: igwn/lalsuite-dev:el7-testing
   extends:
-    - .rpmbuild
+    - .rpmbuild:el7
     - .integration-tests
   before_script:
     # init yum stuff from the template
@@ -1276,13 +1378,13 @@ lalinference_testjob:
     - git lfs clone https://git.ligo.org/lscsoft/ROQ_data --include "**/params.dat,*/4s/**"
     - bash lalinference/test/lalinference_nestedSampling_integration_test.sh
   needs:
-    - lal:rpm
-    - lalframe:rpm
-    - lalmetaio:rpm
-    - lalsimulation:rpm
-    - lalburst:rpm
-    - lalinspiral:rpm
-    - lalinference:rpm
+    - lal:rpm-el7
+    - lalframe:rpm-el7
+    - lalmetaio:rpm-el7
+    - lalsimulation:rpm-el7
+    - lalburst:rpm-el7
+    - lalinspiral:rpm-el7
+    - lalinference:rpm-el7
   artifacts:
     expire_in: 18h
     paths:
@@ -1310,13 +1412,13 @@ lalpulsar_longtests:
     - make -j${CPU_COUNT} check -C bin/longtests/ LONGTESTS=1
   needs:
     - tarballs
-    - lal:rpm
-    - lalframe:rpm
-    - lalmetaio:rpm
-    - lalsimulation:rpm
-    - lalburst:rpm
-    - lalinspiral:rpm
-    - lalinference:rpm
+    - lal:rpm-el7
+    - lalframe:rpm-el7
+    - lalmetaio:rpm-el7
+    - lalsimulation:rpm-el7
+    - lalburst:rpm-el7
+    - lalinspiral:rpm-el7
+    - lalinference:rpm-el7
   artifacts:
     # upload some files to debug failures
     paths:
@@ -1356,20 +1458,9 @@ top-level:pulsar:
   stage: upgrade tests
   artifacts: {}
 
-upgrade:rpm:el7:
+.upgrade:rpm:
   extends:
-    - .rpmbuild
     - .upgrade-test
-  needs:
-    - lal:rpm
-    - lalframe:rpm
-    - lalmetaio:rpm
-    - lalsimulation:rpm
-    - lalburst:rpm
-    - lalinspiral:rpm
-    - lalinference:rpm
-    - lalpulsar:rpm
-    - lalapps:rpm
   script:
     # install latest release
     - yum -y -q install lal* python*-lal* --exclude lalsuite*
@@ -1389,6 +1480,36 @@ upgrade:rpm:el7:
     # install new packages
     - yum -y upgrade
 
+upgrade:rpm-el7:
+  extends:
+    - .rpmbuild:el7
+    - .upgrade:rpm
+  needs:
+    - lal:rpm-el7
+    - lalframe:rpm-el7
+    - lalmetaio:rpm-el7
+    - lalsimulation:rpm-el7
+    - lalburst:rpm-el7
+    - lalinspiral:rpm-el7
+    - lalinference:rpm-el7
+    - lalpulsar:rpm-el7
+    - lalapps:rpm-el7
+
+upgrade:rpm-el8:
+  extends:
+    - .rpmbuild:el8
+    - .upgrade:rpm
+  needs:
+    - lal:rpm-el8
+    - lalframe:rpm-el8
+    - lalmetaio:rpm-el8
+    - lalsimulation:rpm-el8
+    - lalburst:rpm-el8
+    - lalinspiral:rpm-el8
+    - lalinference:rpm-el8
+    - lalpulsar:rpm-el8
+    - lalapps:rpm-el8
+
 upgrade:debian:bullseye:
   extends:
     - .debuild