Relax tolerance on frame check in NR
Hi @ian-harry,
The following condition [1] was being activated when @gayathri.v was trying to perform injections with CWB and NR waveforms.
The LVCNR waveform GT0888.h5 was causing this error. I tracked it down to being caused by the particular value of coa_phase
being used.
For some reason having coa_phase= 3.7733601 was causing this error. Other values worked but values in close-ish proximity to 3.77 did not. e.g., coa_phase= 3.3 works...
I printed the values the values corresponding to the if statement in [1] and get the following
y_val = -0.1798866977695660
z_wave_y = -0.1794079524378455
fabs(y_val - z_wave_y) = 0.0004787453317205
Do you think we can just relax the tolerance a bit from 0.0001
to 0.001
? Or should this be precise?
Any ideas?
[1] https://git.ligo.org/lscsoft/lalsuite/blob/master/lalsimulation/src/LALSimIMRNRWaveforms.c#L496-499