Skip to content

Move some lalinspiral code around

Kipp Cannon requested to merge (removed):move_LALInspiralParseParameters_to_new_homes into master

Description

3 patches that re-organize some lalinspiral code, mostly moving declarations between header files to simply dependencies.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Most of LALInspiralParseParameters.c is simply the command line parsing code for one of lalinspiral's unit tests. One of the 3 patches moves that code into the unit test itself, removing it from the exported API. The other patches don't change the exported ABI but do change the API by changing what header file needs to be #included to get the symbol definitions. There are no practical consequences at the moment because all the code that uses the symbols in question already #includes all relevant header files.

Review Status

Not reviewed.

Merge request reports