ligo.skymap issueshttps://git.ligo.org/lscsoft/ligo.skymap/-/issues2024-03-18T20:14:33Zhttps://git.ligo.org/lscsoft/ligo.skymap/-/issues/49Feature request: add kwarg for skypost.obj name in ligo-skymap-from-samples2024-03-18T20:14:33ZGeoffrey MoFeature request: add kwarg for skypost.obj name in ligo-skymap-from-samplesIn https://git.ligo.org/lscsoft/ligo.skymap/-/blob/main/ligo/skymap/tool/ligo_skymap_from_samples.py#L147, the `skypost.obj` output name is hardcoded. If `ligo-skymap-from-samples` is run multiple times with the same outdir, then `skypos...In https://git.ligo.org/lscsoft/ligo.skymap/-/blob/main/ligo/skymap/tool/ligo_skymap_from_samples.py#L147, the `skypost.obj` output name is hardcoded. If `ligo-skymap-from-samples` is run multiple times with the same outdir, then `skypost.obj` gets overwritten. It would be nice for a kwarg to be added that allows the skypost name to be selected, in the same way that there is a `fitsoutname` option (https://git.ligo.org/lscsoft/ligo.skymap/-/blob/main/ligo/skymap/tool/ligo_skymap_from_samples.py#L53).https://git.ligo.org/lscsoft/ligo.skymap/-/issues/46Add automated benchmark2024-02-20T17:57:25ZLeo P. SingerAdd automated benchmarkAdd benchmark to acceptance tests. See https://lscsoft.docs.ligo.org/ligo.skymap/performance.html, https://git.ligo.org/leo-singer/ligo-skymap-benchmark.Add benchmark to acceptance tests. See https://lscsoft.docs.ligo.org/ligo.skymap/performance.html, https://git.ligo.org/leo-singer/ligo-skymap-benchmark.https://git.ligo.org/lscsoft/ligo.skymap/-/issues/41Request more memory , for bayestar_localize_coincs when run with condor process2023-09-28T13:59:58ZWeizmann KIENDREBEOGORequest more memory , for bayestar_localize_coincs when run with condor processHi @leo-singer ,
the simulation of Observing scenarios need more memory
about condor process.
https://git.ligo.org/lscsoft/ligo.skymap/-/blob/main/ligo/skymap/tool/bayestar_localize_coincs.py#L132
I suggest we go up to `request_memory...Hi @leo-singer ,
the simulation of Observing scenarios need more memory
about condor process.
https://git.ligo.org/lscsoft/ligo.skymap/-/blob/main/ligo/skymap/tool/bayestar_localize_coincs.py#L132
I suggest we go up to `request_memory = 2000 MB`
44 CBCs are failled cause of : MemoryUsage 1612MB > 1.5*RequestMemory 1000MB.https://git.ligo.org/lscsoft/ligo.skymap/-/issues/39Document meaning of "coherent vs incoherent BF"2023-07-04T14:53:10ZJacopo TissinoDocument meaning of "coherent vs incoherent BF"Part of the output from BAYESTAR are the signal vs. noise and coherent vs. incoherent Bayes factors.
The latter is also shown on GraceDB.
It seems to me that these are not described anywhere in the documentation, nor in the BAYESTAR pap...Part of the output from BAYESTAR are the signal vs. noise and coherent vs. incoherent Bayes factors.
The latter is also shown on GraceDB.
It seems to me that these are not described anywhere in the documentation, nor in the BAYESTAR papers:
it would be useful to, at least, have a reference to section V.C in [Veitch and Vecchio 2010](http://arxiv.org/abs/0911.3820) for the coherent vs. incoherent BF, which may be less familiar
than the signal vs. noise one, but more details on both would be nice.
I don't see an obvious place in the documentation for this to go at the moment, but I'd be happy to make
a MR once that is determined.
For reference, [this](https://git.ligo.org/computing/gracedb/server/-/issues/317) is the issue
I had opened on GraceDB asking for the same thing, but it was out of scope there.https://git.ligo.org/lscsoft/ligo.skymap/-/issues/32Build fails when cross-compiling2022-02-03T14:35:07ZDuncan Macleodduncan.macleod@ligo.orgBuild fails when cross-compilingAttempting to cross-compile ligo.skymap on macOS x86_64 for macOS arm64 results in a build failure attempting to detect openmp:
```
File "setup.py", line 126, in <module>
ext_modules=get_extensions())
File "setup.py", line...Attempting to cross-compile ligo.skymap on macOS x86_64 for macOS arm64 results in a build failure attempting to detect openmp:
```
File "setup.py", line 126, in <module>
ext_modules=get_extensions())
File "setup.py", line 55, in get_extensions
add_openmp_flags_if_available(extension)
File "/Users/duncanmacleod/opt/mambaforge/conda-bld/ligo.skymap_1643881988664/_build_env/venv/lib/python3.10/site-packages/extension_helpers/_openmp_helpers.py", line 245, in add_openmp_flags_if_available
using_openmp = check_openmp_support(openmp_flags=openmp_flags)
File "/Users/duncanmacleod/opt/mambaforge/conda-bld/ligo.skymap_1643881988664/_build_env/venv/lib/python3.10/site-packages/extension_helpers/_openmp_helpers.py", line 198, in check_openmp_support
output = subprocess.check_output('./test_openmp')
File "/Users/duncanmacleod/opt/mambaforge/conda-bld/ligo.skymap_1643881988664/_build_env/lib/python3.10/subprocess.py", line 420, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "/Users/duncanmacleod/opt/mambaforge/conda-bld/ligo.skymap_1643881988664/_build_env/lib/python3.10/subprocess.py", line 501, in run
with Popen(*popenargs, **kwargs) as process:
File "/Users/duncanmacleod/opt/mambaforge/conda-bld/ligo.skymap_1643881988664/_build_env/lib/python3.10/subprocess.py", line 966, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/Users/duncanmacleod/opt/mambaforge/conda-bld/ligo.skymap_1643881988664/_build_env/lib/python3.10/subprocess.py", line 1842, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
OSError: [Errno 86] Bad CPU type in executable: './test_openmp'
error: subprocess-exited-with-error
```
This stems from `extension-helpers`, for which github redirects me to [`astropy-helpers`](https://github.com/astropy/astropy-helpers/), whose README states:
> Note: astropy-helpers is deprecated. As justified and described in APE17, the astropy-helpers infrastructure is no longer used for Astropy coordinated or infrastructure packages, and hence has limited-to-no maintainience from 2021 onwards.
So, maybe it's time to stop using that tool and detect openmp in a different way that supports cross-compiling.https://git.ligo.org/lscsoft/ligo.skymap/-/issues/27Fail if SNR time series is not found?2021-09-17T12:07:01ZTito Dal CantonFail if SNR time series is not found?There has been a case where malformed LIGOLW XML trigger files led to BAYESTAR effectively ignoring the SNR time series even if it was present. The problem was discovered by pure chance. Would it make sense for BAYESTAR to *require* the ...There has been a case where malformed LIGOLW XML trigger files led to BAYESTAR effectively ignoring the SNR time series even if it was present. The problem was discovered by pure chance. Would it make sense for BAYESTAR to *require* the presence of the SNR time series, and only fall back to the old approach when explicitly requested on the command line?https://git.ligo.org/lscsoft/ligo.skymap/-/issues/23make_rect_poly returns nans if half-diagonal angle is >90°2020-12-31T16:32:08ZLeo P. Singermake_rect_poly returns nans if half-diagonal angle is >90°make_rect_poly returns nans if the angle from the center of the polygon to the vertices is >90°. This is because the edges of the rectangle are currently defined as small circles (spheric sections) formed by the intersection of a 3D rect...make_rect_poly returns nans if the angle from the center of the polygon to the vertices is >90°. This is because the edges of the rectangle are currently defined as small circles (spheric sections) formed by the intersection of a 3D rectangular prism with the sphere, and for sufficiently large polygons, the edges do not intersect at all on the surface of the sphere.
The edges should instead be defined as great circles, which will allow for the edges to intersect even for large angles. Great circles are probably also more consistent with a user's expectation that the figure drawn by make_rect_poly is the same as the footprint of a gnomonic WCS projection (`CTYPE1="RA---TAN"`, `CTYPE2="DEC--TAN"`), because in a gnomonic projection, all straight lines (including the edges of the projection) are great circles. (The gnomonic projection is the most common projection used in optical astronomy.)https://git.ligo.org/lscsoft/ligo.skymap/-/issues/22Support non-LIGO_LW XML output formats for tools2020-05-18T15:53:08ZDuncan Macleodduncan.macleod@ligo.orgSupport non-LIGO_LW XML output formats for toolsIs it reasonable to consider supporting non-LIGO_LW-XML output formats for tools, e.g. `bayestar-inject`? Supporting HDF5 and/or JSON as appropriate would be very nice and might help spur a transition away from XML.
Happy to help.Is it reasonable to consider supporting non-LIGO_LW-XML output formats for tools, e.g. `bayestar-inject`? Supporting HDF5 and/or JSON as appropriate would be very nice and might help spur a transition away from XML.
Happy to help.https://git.ligo.org/lscsoft/ligo.skymap/-/issues/19Update cosmological parameters to Planck 20182021-04-21T16:44:39ZLeo P. SingerUpdate cosmological parameters to Planck 2018We are waiting for Planck2018 to be fully integrated into Astropy. See [astropy/astropy#9515](https://github.com/astropy/astropy/issues/9515).We are waiting for Planck2018 to be fully integrated into Astropy. See [astropy/astropy#9515](https://github.com/astropy/astropy/issues/9515).https://git.ligo.org/lscsoft/ligo.skymap/-/issues/17Produce refined arrival time2022-01-25T16:54:23ZLeo P. SingerProduce refined arrival time@erik-katsavounidis points out that the event times in GraceDB have an ambiguous spatial reference. Teach BAYESTAR and (for LALInference and Bilby) ligo-skymap-from-samples to estimate refined geocenter arrival times.@erik-katsavounidis points out that the event times in GraceDB have an ambiguous spatial reference. Teach BAYESTAR and (for LALInference and Bilby) ligo-skymap-from-samples to estimate refined geocenter arrival times.