ligo.skymap issueshttps://git.ligo.org/lscsoft/ligo.skymap/-/issues2020-12-31T16:32:08Zhttps://git.ligo.org/lscsoft/ligo.skymap/-/issues/23make_rect_poly returns nans if half-diagonal angle is >90°2020-12-31T16:32:08ZLeo P. Singermake_rect_poly returns nans if half-diagonal angle is >90°make_rect_poly returns nans if the angle from the center of the polygon to the vertices is >90°. This is because the edges of the rectangle are currently defined as small circles (spheric sections) formed by the intersection of a 3D rectangular prism with the sphere, and for sufficiently large polygons, the edges do not intersect at all on the surface of the sphere.
The edges should instead be defined as great circles, which will allow for the edges to intersect even for large angles. Great circles are probably also more consistent with a user's expectation that the figure drawn by make_rect_poly is the same as the footprint of a gnomonic WCS projection (`CTYPE1="RA---TAN"`, `CTYPE2="DEC--TAN"`), because in a gnomonic projection, all straight lines (including the edges of the projection) are great circles. (The gnomonic projection is the most common projection used in optical astronomy.)make_rect_poly returns nans if the angle from the center of the polygon to the vertices is >90°. This is because the edges of the rectangle are currently defined as small circles (spheric sections) formed by the intersection of a 3D rectangular prism with the sphere, and for sufficiently large polygons, the edges do not intersect at all on the surface of the sphere.
The edges should instead be defined as great circles, which will allow for the edges to intersect even for large angles. Great circles are probably also more consistent with a user's expectation that the figure drawn by make_rect_poly is the same as the footprint of a gnomonic WCS projection (`CTYPE1="RA---TAN"`, `CTYPE2="DEC--TAN"`), because in a gnomonic projection, all straight lines (including the edges of the projection) are great circles. (The gnomonic projection is the most common projection used in optical astronomy.)https://git.ligo.org/lscsoft/ligo.skymap/-/issues/22Support non-LIGO_LW XML output formats for tools2020-05-18T15:53:08ZDuncan Macleodduncan.macleod@ligo.orgSupport non-LIGO_LW XML output formats for toolsIs it reasonable to consider supporting non-LIGO_LW-XML output formats for tools, e.g. `bayestar-inject`? Supporting HDF5 and/or JSON as appropriate would be very nice and might help spur a transition away from XML.
Happy to help.Is it reasonable to consider supporting non-LIGO_LW-XML output formats for tools, e.g. `bayestar-inject`? Supporting HDF5 and/or JSON as appropriate would be very nice and might help spur a transition away from XML.
Happy to help.https://git.ligo.org/lscsoft/ligo.skymap/-/issues/19Update cosmological parameters to Planck 20182021-04-21T16:44:39ZLeo P. SingerUpdate cosmological parameters to Planck 2018We are waiting for Planck2018 to be fully integrated into Astropy. See [astropy/astropy#9515](https://github.com/astropy/astropy/issues/9515).We are waiting for Planck2018 to be fully integrated into Astropy. See [astropy/astropy#9515](https://github.com/astropy/astropy/issues/9515).https://git.ligo.org/lscsoft/ligo.skymap/-/issues/17Produce refined arrival time2021-02-11T18:36:11ZLeo P. SingerProduce refined arrival time@erik-katsavounidis points out that the event times in GraceDB have an ambiguous spatial reference. Teach BAYESTAR and (for LALInference and Bilby) ligo-skymap-from-samples to estimate refined geocenter arrival times.@erik-katsavounidis points out that the event times in GraceDB have an ambiguous spatial reference. Teach BAYESTAR and (for LALInference and Bilby) ligo-skymap-from-samples to estimate refined geocenter arrival times.