O4-Review.md

@@ -58,7 +58,8 @@ During the review we updated pbilby to 2.0.2, in which the main changes were:
 | [GW191109](#gw191109) | Rory | ✓ | see review statement |
 | [GW200208](#gw200208) | Rory | ✓ | :white_check_mark: [@simon-stevenson](#) |
 | [Fiducial BBH Inj](#fiducial-bbh-inj) | Avi | ✓ | :white_check_mark: [@simon-stevenson](#) |
-| [Scaling test](#scaling-test) | Avi | ✓ | :white_check_mark: [@simon-stevenson](#) |
+| [BBH Scaling test](#bbh-scaling-test) | Avi | ✓ | :white_check_mark: [@simon-stevenson](#) |
+| [BNS Scaling test](#bns-scaling-test) | Avi | ✓ |  |
 | [4s BBH PP-test](#4s-bbh-pp-test) | Avi | ✓ | :white_check_mark: [@simon-stevenson](#) |
 | [16s BBH PP-test](#16s-bbh-pp-test) | Avi | ✓ | :white_check_mark: [@simon-stevenson](#) |
 | [64s NSBH PP-test](#64s-bbh-pp-test) | Avi | ✓ | :white_check_mark: [@simon-stevenson](#) |
@@ -559,7 +560,7 @@ waveform-approximant = IMRPhenomXPHM
 
 </details>
 
-## Scaling test
+## BBH Scaling test
 
 Ran the above [Fiducial 4s BBH Inj](#fiducial-bbh-inj) with nCPU 32, 64, 128.
 
@@ -581,6 +582,96 @@ Ran the above [Fiducial 4s BBH Inj](#fiducial-bbh-inj) with nCPU 32, 64, 128.
 | ![](uploads/c7e58df9f02943cc674e51337e018c61/scaling_metadata.png){height="500"} |
 | ![](uploads/81612c80fde5285764e850f795fd0e84/scaling_1d_histograms.png){height="1000"} |
 
+</details>
+
+
+## BBH Scaling test
+
+Analysed a 128s BNS injection with nCPU 8, 16, 32.
+
+<details>
+<summary>Config</summary>
+
+```ini
+label = 128s_<NCPU>cpu
+outdir = out_<NCPU>cpu
+ntasks-per-node = <NCPU>
+## CONSTANTS ##
+injection-numbers = [0]
+generation-seed = 0
+time = 10:00:00
+prior-file = /fred/oz170/rsmith/git/pbilby_o4_review/pp_tests/bns_128s/128s.prior
+injection-file = /fred/oz170/rsmith/git/pbilby_o4_review/pp_tests/bns_128s/injections.dat
+likelihood-type=ROQGravitationalWaveTransient
+roq-linear-matrix=/fred/oz170/rsmith/ROQs/basis_128s.hdf5
+roq-quadratic-matrix=/fred/oz170/rsmith/ROQs/basis_128s.hdf5
+gaussian-noise = True
+maximum-frequency = 2048
+minimum-frequency = 20
+trigger-time = 0
+injection = True
+detectors = [H1, L1]
+psd_dict = None
+duration = 128
+distance-marginalization = True
+phase-marginalization = True
+time-marginalization = False
+jitter-time = True
+reference-frame = H1L1
+time-reference = geocent
+waveform-approximant = IMRPhenomPv2_NRTidalv2
+catch-waveform-errors = True
+enforce-signal-duration = False
+nlive = 1000
+slurm-extra-lines='tmp=1000'
+nact = 50
+nodes = 1
+mem-per-cpu = 8000
+extra-lines = module load python-scientific/3.10.4-foss-2022a && source /fred/oz980/avajpeyi/envs/milan_venv/bin/activate
+```
+
+```python
+chirp_mass = bilby.gw.prior.UniformInComponentsChirpMass(minimum=1.5, maximum=2.3, name='chirp_mass', latex_label='$\\mathcal{M}$', unit=None, boundary=None)
+mass_ratio = bilby.gw.prior.UniformInComponentsMassRatio(minimum=0.05, maximum=1, name='mass_ratio', latex_label='$q$', unit=None, boundary=None)
+mass_1 = Constraint(minimum=1, maximum=1000, name=None, latex_label=None, unit=None)
+mass_2 = Constraint(minimum=1, maximum=1000, name=None, latex_label=None, unit=None)
+a_1 = Uniform(minimum=0, maximum=0.4, name=None, latex_label=None, unit=None, boundary=None)
+a_2 = Uniform(minimum=0, maximum=0.4, name=None, latex_label=None, unit=None, boundary=None)
+tilt_1 = Sine(minimum=0, maximum=3.141592653589793, name='tilt_1', latex_label='$\\theta_1$', unit=None, boundary=None)
+tilt_2 = Sine(minimum=0, maximum=3.141592653589793, name='tilt_2', latex_label='$\\theta_2$', unit=None, boundary=None)
+phi_12 = Uniform(minimum=0, maximum=6.283185307179586, name='phi_12', latex_label='$\\Delta\\phi$', unit=None, boundary='periodic')
+phi_jl = Uniform(minimum=0, maximum=6.283185307179586, name='phi_jl', latex_label='$\\phi_{JL}$', unit=None, boundary='periodic')
+luminosity_distance = bilby.gw.prior.UniformSourceFrame(minimum=1.0, maximum=150.0, name='luminosity_distance', latex_label='$d_L$', unit="Mpc", boundary=None)
+dec = Cosine(minimum=-1.5707963267948966, maximum=1.5707963267948966, name='dec', latex_label='$\\mathrm{DEC}$', unit=None, boundary=None)
+ra = Uniform(minimum=0, maximum=6.283185307179586, name='ra', latex_label='$\\mathrm{RA}$', unit=None, boundary='periodic')
+theta_jn = Sine(minimum=0, maximum=3.141592653589793, name='theta_jn', latex_label='$\\theta_{JN}$', unit=None, boundary=None)
+psi = Uniform(minimum=0, maximum=3.141592653589793, name='psi', latex_label='$\\psi$', unit=None, boundary='periodic')
+phase = Uniform(minimum=0, maximum=6.283185307179586, name='phase', latex_label='$\\phi$', unit=None, boundary='periodic')
+lambda_1 = Uniform(minimum=0, maximum=5000, latex_label="$\\Lambda_{1}$")
+lambda_2 = Uniform(minimum=0, maximum=5000, latex_label="$\\Lambda_{2}$")
+geocent_time = Uniform(minimum=-0.1, maximum=0.1, name=None, latex_label=None, unit=None, boundary=None)
+```
+
+</details>
+
+
+<details>
+<summary>Results</summary>
+
+|   ncpu |    time |   nsamples |   log_evidence |   log_evidence_err |
+|-------:|--------:|-----------:|---------------:|-------------------:|
+|      8 | 82551.1 |       5764 |        -519220 |           0.175312 |
+|     16 | 53819.2 |       5597 |        -519220 |           0.174741 |
+|     32 | 43447.5 |       5693 |        -519220 |           0.176116 |
+
+
+| Plots |
+|-------|
+| ![](uploads/1fbb4291c8d0449acbd9a77210d87698/scaling_metadata.png){height="500"} |
+| ![](uploads/b35c13ece365fc4bdba904007113ad67/scaling_1d_histograms.png){height="1000"} |
+
+
+
 </details>
 
 ## 4s BBH PP Test