Changes

Page history
Update PESummary Review authored by Charlie Hoy's avatar Charlie Hoy
Show whitespace changes
Inline Side-by-side
PESummary-Review.md
View page @ 800a95cb
...@@ -21,11 +21,11 @@ ...@@ -21,11 +21,11 @@
* *
# Code version ## Code version
* `pesummary`: [0.3.3](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.3.3) * `pesummary`: [0.3.3](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.3.3)
# Links to tests ### Links to tests
> Mark complete with `:white_check_mark:` and incomplete with `:x:` > Mark complete with `:white_check_mark:` and incomplete with `:x:`
...@@ -38,9 +38,9 @@ ...@@ -38,9 +38,9 @@
| Downloadable files check | [Downloadable files](https://git.ligo.org/lscsoft/pesummary/-/wikis/Downloadable-files) | @charlie.hoy | @nicola.delillo | :white_check_mark: | [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) | :heavy_check_mark: | | Downloadable files check | [Downloadable files](https://git.ligo.org/lscsoft/pesummary/-/wikis/Downloadable-files) | @charlie.hoy | @nicola.delillo | :white_check_mark: | [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) | :heavy_check_mark: |
| Documentation check | [Documentation](https://git.ligo.org/lscsoft/pesummary/-/wikis/Documentation) | @charlie.hoy | @philip.relton | :white_check_mark: | [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) |:heavy_check_mark: | | Documentation check | [Documentation](https://git.ligo.org/lscsoft/pesummary/-/wikis/Documentation) | @charlie.hoy | @philip.relton | :white_check_mark: | [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) |:heavy_check_mark: |
## Review Telecons ### Review Telecons
## Final Review Statement ### Final Review Statement
PESummary is now reviewed in its standard configuration. We have run our tests on git hash: [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) . PESummary is now reviewed in its standard configuration. We have run our tests on git hash: [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) .
PESummary is able to post process posterior samples using the correct PESummary is able to post process posterior samples using the correct
parameter conversions, in agreement with `cbcBayesProc` [1]. PESummary ’s skymaps are also in agreement with `Ligo.skymap` [2]. parameter conversions, in agreement with `cbcBayesProc` [1]. PESummary ’s skymaps are also in agreement with `Ligo.skymap` [2].
...@@ -79,11 +79,11 @@ To perform the review tasks, we are using the sample release associated with GW1 ...@@ -79,11 +79,11 @@ To perform the review tasks, we are using the sample release associated with GW1
# Amendment 1 # Amendment 1
# Code version ## Code version
* `pesummary`: [0.4.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.4.0) * `pesummary`: [0.4.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.4.0)
# Links to tests ### Links to tests
> Mark complete with `:white_check_mark:` and incomplete with `:x:` > Mark complete with `:white_check_mark:` and incomplete with `:x:`
...@@ -94,15 +94,15 @@ To perform the review tasks, we are using the sample release associated with GW1 ...@@ -94,15 +94,15 @@ To perform the review tasks, we are using the sample release associated with GW1
| Evolved remnant fits for precessing PE runs| [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#spin-evolution-for-nrutils-fits)| @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | [18b79318](https://git.ligo.org/lscsoft/pesummary/-/tree/18b79318f53f66750150b4159c6bf8c427fe37db) | :heavy_check_mark: | | Evolved remnant fits for precessing PE runs| [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#spin-evolution-for-nrutils-fits)| @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | [18b79318](https://git.ligo.org/lscsoft/pesummary/-/tree/18b79318f53f66750150b4159c6bf8c427fe37db) | :heavy_check_mark: |
| Surrogate remnant fits for precessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#surrogate-fits) | @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | [148b45dc](https://git.ligo.org/lscsoft/pesummary/-/commit/148b45dc323010f597acb7c205aea0030898ccd8) | :heavy_check_mark: | | Surrogate remnant fits for precessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#surrogate-fits) | @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | [148b45dc](https://git.ligo.org/lscsoft/pesummary/-/commit/148b45dc323010f597acb7c205aea0030898ccd8) | :heavy_check_mark: |
## Review Telecons ### Review Telecons
# Amendment 2 # Amendment 2
# Code version ## Code version
* `pesummary`: [0.5.1](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.5.1) * `pesummary`: [0.5.1](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.5.1)
# Links to tests ### Links to tests
> Mark complete with `:white_check_mark:` and incomplete with `:x:` > Mark complete with `:white_check_mark:` and incomplete with `:x:`
...@@ -111,15 +111,15 @@ To perform the review tasks, we are using the sample release associated with GW1 ...@@ -111,15 +111,15 @@ To perform the review tasks, we are using the sample release associated with GW1
| SEOBNRv4PHM and IMRPhenomPv3HM remnant fits for precessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#seobnrv4phm-and-imrphenompv3hm-fits) | @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | 35d4170c76f1fd2f8a3fe012736a6d1fc96b08e8 | :heavy_check_mark: | | SEOBNRv4PHM and IMRPhenomPv3HM remnant fits for precessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#seobnrv4phm-and-imrphenompv3hm-fits) | @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | 35d4170c76f1fd2f8a3fe012736a6d1fc96b08e8 | :heavy_check_mark: |
| `chi_p` bug | [`chi_p` bug](https://git.ligo.org/charlie.hoy/pesummary_bug/-/wikis/Review-of-chi_p-bug-script#sign-off) | @charlie.hoy | @nathan-johnson-mcdaniel | :white_check_mark: | https://git.ligo.org/lscsoft/pesummary/-/commit/70ac22ed59653090748170f6962c5ac0064c3e82 | :heavy_check_mark: | | `chi_p` bug | [`chi_p` bug](https://git.ligo.org/charlie.hoy/pesummary_bug/-/wikis/Review-of-chi_p-bug-script#sign-off) | @charlie.hoy | @nathan-johnson-mcdaniel | :white_check_mark: | https://git.ligo.org/lscsoft/pesummary/-/commit/70ac22ed59653090748170f6962c5ac0064c3e82 | :heavy_check_mark: |
## Review Telecons ### Review Telecons
# Amendment 3 # Amendment 3
# Code version ## Code version
* `pesummary`: [0.5.3](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.5.3) * `pesummary`: [0.5.3](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.5.3)
# Links to tests ### Links to tests
> Mark complete with `:white_check_mark:` and incomplete with `:x:` > Mark complete with `:white_check_mark:` and incomplete with `:x:`
...@@ -129,16 +129,16 @@ To perform the review tasks, we are using the sample release associated with GW1 ...@@ -129,16 +129,16 @@ To perform the review tasks, we are using the sample release associated with GW1
| Correctly store `ligo.skymap` statistics in the meta file | [skymap statistics](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.5.3#ligoskymap-statistics-commit-hash-used-for-test-f159de8) | @charlie.hoy | @virginia.demilio | :white_check_mark: | f159de8e | :heavy_check_mark: | | Correctly store `ligo.skymap` statistics in the meta file | [skymap statistics](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.5.3#ligoskymap-statistics-commit-hash-used-for-test-f159de8) | @charlie.hoy | @virginia.demilio | :white_check_mark: | f159de8e | :heavy_check_mark: |
| LAL redshift calculation | [Redshift](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.5.3#lal-redshift-commit-hash-used-for-test-f159de8) | @charlie.hoy | @virginia.demilio | :white_check_mark: | f159de8e | :heavy_check_mark: | | LAL redshift calculation | [Redshift](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.5.3#lal-redshift-commit-hash-used-for-test-f159de8) | @charlie.hoy | @virginia.demilio | :white_check_mark: | f159de8e | :heavy_check_mark: |
## Review Telecons ### Review Telecons
# Amendment 4 # Amendment 4
# Code version ## Code version
* `pesummary`: [0.5.4](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.5.4) * `pesummary`: [0.5.4](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.5.4)
# Links to tests ### Links to tests
> Mark complete with `:white_check_mark:` and incomplete with `:x:` > Mark complete with `:white_check_mark:` and incomplete with `:x:`
...@@ -152,11 +152,11 @@ To perform the review tasks, we are using the sample release associated with GW1 ...@@ -152,11 +152,11 @@ To perform the review tasks, we are using the sample release associated with GW1
# Amendment 5 # Amendment 5
# Code version ## Code version
* `pesummary`: [0.5.6](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.5.6) * `pesummary`: [0.5.6](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.5.6)
# Links to tests ### Links to tests
> Mark complete with `:white_check_mark:` and incomplete with `:x:` > Mark complete with `:white_check_mark:` and incomplete with `:x:`
...@@ -167,15 +167,15 @@ To perform the review tasks, we are using the sample release associated with GW1 ...@@ -167,15 +167,15 @@ To perform the review tasks, we are using the sample release associated with GW1
| Parallelisation of spin evolution | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#parallelisation-of-spin-evolution-for-nrutils-fits)| @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel @nicola.delillo | :white_check_mark: | cf66e2e4 | :heavy_check_mark: | | Parallelisation of spin evolution | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#parallelisation-of-spin-evolution-for-nrutils-fits)| @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel @nicola.delillo | :white_check_mark: | cf66e2e4 | :heavy_check_mark: |
| Parallelisation of exact redshift computation | [Redshift](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.5.6#parallelising-exact-redshift-computation)| @charlie.hoy | @philip.relton | :white_check_mark: | fbf36e3a | :heavy_check_mark: | | Parallelisation of exact redshift computation | [Redshift](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.5.6#parallelising-exact-redshift-computation)| @charlie.hoy | @philip.relton | :white_check_mark: | fbf36e3a | :heavy_check_mark: |
## Review Telecons ### Review Telecons
# Amendment 6 # Amendment 6
# Code version ## Code version
* `pesummary`: [0.6.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.6.0) * `pesummary`: [0.6.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.6.0)
# Links to tests ### Links to tests
> Mark complete with `:white_check_mark:` and incomplete with `:x:` > Mark complete with `:white_check_mark:` and incomplete with `:x:`
...@@ -183,15 +183,15 @@ To perform the review tasks, we are using the sample release associated with GW1 ...@@ -183,15 +183,15 @@ To perform the review tasks, we are using the sample release associated with GW1
| ---- | ----------------- | ------------------ | -------- | ------ | ------------- | --------------- | | ---- | ----------------- | ------------------ | -------- | ------ | ------------- | --------------- |
| Jensen-Shannon divergence | [jensen-shannon tests](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.6.0#jensen-shannon-divergence-calculation) | @charlie.hoy | @philip.relton | \:white_check_mark: | 6b80028a | :heavy_check_mark: | | Jensen-Shannon divergence | [jensen-shannon tests](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.6.0#jensen-shannon-divergence-calculation) | @charlie.hoy | @philip.relton | \:white_check_mark: | 6b80028a | :heavy_check_mark: |
## Review Telecons ### Review Telecons
# Amendment 7 # Amendment 7
# Code version ## Code version
* `pesummary`: [0.7.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.7.0) * `pesummary`: [0.7.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.7.0)
# Links to tests ### Links to tests
> Mark complete with `:white_check_mark:` and incomplete with `:x:` > Mark complete with `:white_check_mark:` and incomplete with `:x:`
...@@ -199,15 +199,15 @@ To perform the review tasks, we are using the sample release associated with GW1 ...@@ -199,15 +199,15 @@ To perform the review tasks, we are using the sample release associated with GW1
| ---- | ----------------- | ------------------ | -------- | ------ | ------------- | --------------- | | ---- | ----------------- | ------------------ | -------- | ------ | ------------- | --------------- |
| Comparison to `cbcBayesPostProc` | [Comparison](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.7.0#comparison-to-cbcbayespostproc) | @charlie.hoy | @philip.relton | :white_check_mark: | 3c418aef | \:heavy_check_mark: | | Comparison to `cbcBayesPostProc` | [Comparison](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.7.0#comparison-to-cbcbayespostproc) | @charlie.hoy | @philip.relton | :white_check_mark: | 3c418aef | \:heavy_check_mark: |
## Review Telecons ### Review Telecons
# Amendment 8 # Amendment 8
# Code version ## Code version
* `pesummary`: [0.8.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.8.0) * `pesummary`: [0.8.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.8.0)
# Links to tests ### Links to tests
> Mark complete with `:white_check_mark:` and incomplete with `:x:` > Mark complete with `:white_check_mark:` and incomplete with `:x:`
...@@ -220,15 +220,15 @@ To perform the review tasks, we are using the sample release associated with GW1 ...@@ -220,15 +220,15 @@ To perform the review tasks, we are using the sample release associated with GW1
| Spin disk plots | [Review](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.8.0#spin-disk-plot) | @charlie.hoy | @philip.relton | :white_check_mark: | 9d79de80 | :heavy_check_mark: | | Spin disk plots | [Review](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.8.0#spin-disk-plot) | @charlie.hoy | @philip.relton | :white_check_mark: | 9d79de80 | :heavy_check_mark: |
| Conditioned prior | [Review](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.8.0#prior-conditioning) | @charlie.hoy | @virginia.demilio | :white_check_mark: | https://git.ligo.org/lscsoft/pesummary/-/commit/61bd16eaf2e7346d723f03d4065623a463fe980b | :heavy_check_mark: | | Conditioned prior | [Review](https://git.ligo.org/lscsoft/pesummary/-/wikis/v0.8.0#prior-conditioning) | @charlie.hoy | @virginia.demilio | :white_check_mark: | https://git.ligo.org/lscsoft/pesummary/-/commit/61bd16eaf2e7346d723f03d4065623a463fe980b | :heavy_check_mark: |
## Review Telecons ### Review Telecons
# Amendment 9 # Amendment 9
# Code version ## Code version
* `pesummary`: [0.9.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.9.0) * `pesummary`: [0.9.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.9.0)
# Links to tests ### Links to tests
> Mark complete with `:white_check_mark:` and incomplete with `:x:` > Mark complete with `:white_check_mark:` and incomplete with `:x:`
...@@ -236,15 +236,15 @@ To perform the review tasks, we are using the sample release associated with GW1 ...@@ -236,15 +236,15 @@ To perform the review tasks, we are using the sample release associated with GW1
| ---- | ----------------- | ------------------ | -------- | ------ | ------------- | --------------- | | ---- | ----------------- | ------------------ | -------- | ------ | ------------- | --------------- |
| `network_matched_filter_snr` bug | [`network_matched_filter_snr` bug](https://git.ligo.org/charlie.hoy/pesummary_bug/-/wikis/Review-of-network_matched_filter_snr-bug-script#sign-off) | @charlie.hoy | @vivien | :white_check_mark: | [376af2c0](https://git.ligo.org/lscsoft/pesummary/-/merge_requests/428/diffs?commit_id=376af2c0537d07be2d658e1705c20535260375a0) | :heavy_check_mark: | | `network_matched_filter_snr` bug | [`network_matched_filter_snr` bug](https://git.ligo.org/charlie.hoy/pesummary_bug/-/wikis/Review-of-network_matched_filter_snr-bug-script#sign-off) | @charlie.hoy | @vivien | :white_check_mark: | [376af2c0](https://git.ligo.org/lscsoft/pesummary/-/merge_requests/428/diffs?commit_id=376af2c0537d07be2d658e1705c20535260375a0) | :heavy_check_mark: |
## Review Telecons ### Review Telecons
# Amendment 10 # Amendment 10
# Code version ## Code version
* `pesummary`: [0.10.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.10.0) * `pesummary`: [0.10.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.10.0)
# Links to tests ### Links to tests
> Mark complete with `:white_check_mark:` and incomplete with `:x:` > Mark complete with `:white_check_mark:` and incomplete with `:x:`
...@@ -260,4 +260,4 @@ To perform the review tasks, we are using the sample release associated with GW1 ...@@ -260,4 +260,4 @@ To perform the review tasks, we are using the sample release associated with GW1
| summarypipe with `pbilby` result files | [!459](https://git.ligo.org/lscsoft/pesummary/-/merge_requests/459) [!460](https://git.ligo.org/lscsoft/pesummary/-/merge_requests/460) | @charlie.hoy | @david.keitel | :white_check_mark: | | | | summarypipe with `pbilby` result files | [!459](https://git.ligo.org/lscsoft/pesummary/-/merge_requests/459) [!460](https://git.ligo.org/lscsoft/pesummary/-/merge_requests/460) | @charlie.hoy | @david.keitel | :white_check_mark: | | |
| Conversion with source frame masses | [!461](https://git.ligo.org/lscsoft/pesummary/-/merge_requests/461) | @charlie.hoy | @david.keitel | :white_check_mark: | | | | Conversion with source frame masses | [!461](https://git.ligo.org/lscsoft/pesummary/-/merge_requests/461) | @charlie.hoy | @david.keitel | :white_check_mark: | | |
## Review Telecons ### Review Telecons
\ No newline at end of file \ No newline at end of file