Changes

Page history
Update PESummary Review authored by Charlie Hoy's avatar Charlie Hoy
Hide whitespace changes
Inline Side-by-side
PESummary-Review.md
View page @ eea3c01c
...@@ -17,9 +17,7 @@ ...@@ -17,9 +17,7 @@
* *
# Code version # `pesummary`: [0.3.3](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.3.3) review
* `pesummary`: [0.3.3](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.3.3)
# Links to tests # Links to tests
...@@ -29,20 +27,14 @@ ...@@ -29,20 +27,14 @@
| Test | Related Resources | Person Responsible | Reviewer | Status | Sign off hash | Final Sign off | | Test | Related Resources | Person Responsible | Reviewer | Status | Sign off hash | Final Sign off |
| ---- | ----------------- | ------------------ | -------- | ------ | ------------- | --------------- | | ---- | ----------------- | ------------------ | -------- | ------ | ------------- | --------------- |
| Comparison to `cbcBayesPostProc` | [SummaryReview script](https://git.ligo.org/lscsoft/pesummary/-/wikis/SummaryReview-script) | @charlie.hoy | @nicola.delillo @vivien | :white_check_mark: | [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) | | | Comparison to `cbcBayesPostProc` | [SummaryReview script](https://git.ligo.org/lscsoft/pesummary/-/wikis/SummaryReview-script) | @charlie.hoy | @nicola.delillo @vivien | :white_check_mark: | [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) | |
| Non-evolved remnant fits for nonprecessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#non-evolved-nrutils-remnant-fits)| @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | 700ceb82 | :heavy_check_mark: |
| Non-evolved remnant fits for precessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#non-evolved-nrutils-remnant-fits)| @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | [1fb27730](https://git.ligo.org/lscsoft/pesummary/-/tree/1fb27730d11f4557712e5cae365caf2d361fb401) | :heavy_check_mark: |
| Behaviour of evolved remnant fits when applied to nonprecessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#spin-evolution-for-nrutils-fits)| @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :construction: | | |
| Evolved remnant fits for precessing PE runs| [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#spin-evolution-for-nrutils-fits)| @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | [18b79318](https://git.ligo.org/lscsoft/pesummary/-/tree/18b79318f53f66750150b4159c6bf8c427fe37db) | :heavy_check_mark: |
| Surrogate remnant fits for precessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#surrogate-fits) | @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | [148b45dc](https://git.ligo.org/lscsoft/pesummary/-/commit/148b45dc323010f597acb7c205aea0030898ccd8) | :heavy_check_mark: |
| SEOBNRv4PHM and IMRPhenomPv3HM remnant fits for precessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#seobnrv4phm-and-imrphenompv3hm-fits) | @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :construction: | | |
| `Ligo.skymap` consistency | [ligo.skymap](https://git.ligo.org/lscsoft/pesummary/-/wikis/ligo-skymap)| @charlie.hoy | @philip.relton @nicola.delillo | :white_check_mark: | | | | `Ligo.skymap` consistency | [ligo.skymap](https://git.ligo.org/lscsoft/pesummary/-/wikis/ligo-skymap)| @charlie.hoy | @philip.relton @nicola.delillo | :white_check_mark: | | |
| PESummary metafile consistency | [Metafile](https://git.ligo.org/lscsoft/pesummary/-/wikis/PESummary-metafile) | @charlie.hoy | @nicola.delillo | :white_check_mark: | [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) | | | PESummary metafile consistency | [Metafile](https://git.ligo.org/lscsoft/pesummary/-/wikis/PESummary-metafile) | @charlie.hoy | @nicola.delillo | :white_check_mark: | [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) | |
| Downloadable files check | [Downloadable files](https://git.ligo.org/lscsoft/pesummary/-/wikis/Downloadable-files) | @charlie.hoy | @nicola.delillo | :white_check_mark: | [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) | | | Downloadable files check | [Downloadable files](https://git.ligo.org/lscsoft/pesummary/-/wikis/Downloadable-files) | @charlie.hoy | @nicola.delillo | :white_check_mark: | [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) | |
| Documentation check | [Documentation](https://git.ligo.org/lscsoft/pesummary/-/wikis/Documentation) | @charlie.hoy | @philip.relton | :white_check_mark: | [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) |:heavy_check_mark: | | Documentation check | [Documentation](https://git.ligo.org/lscsoft/pesummary/-/wikis/Documentation) | @charlie.hoy | @philip.relton | :white_check_mark: | [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) |:heavy_check_mark: |
# Review Telecons ## Review Telecons
# Final Review Statement ## Final Review Statement
PESummary is now reviewed in its standard configuration. We have run our tests on git hash: [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) . PESummary is now reviewed in its standard configuration. We have run our tests on git hash: [4f8b36c3](https://git.ligo.org/lscsoft/pesummary/-/tree/4f8b36c3896bfbe2512a156b1f5bda8f34f23ff7) .
PESummary is able to post process posterior samples using the correct PESummary is able to post process posterior samples using the correct
parameter conversions, in agreement with `cbcBayesProc` [1]. PESummary ’s skymaps are also in agreement with `Ligo.skymap` [2]. parameter conversions, in agreement with `cbcBayesProc` [1]. PESummary ’s skymaps are also in agreement with `Ligo.skymap` [2].
...@@ -77,4 +69,21 @@ While not preventing the review and usage, there are some additional extended fe ...@@ -77,4 +69,21 @@ While not preventing the review and usage, there are some additional extended fe
[5] https://git.ligo.org/lscsoft/pesummary/-/wikis/Documentation [5] https://git.ligo.org/lscsoft/pesummary/-/wikis/Documentation
# Notes # Notes
To perform the review tasks, we are using the sample release associated with GW190425. The PESummary metafile containing results can be found here: https://dcc.ligo.org/public/0165/P2000026/001/GW190425_posterior_samples.h5. For comparisons to lalinference, we use the PROD0 run: https://git.ligo.org/pe/O3/S190425z/-/blob/master/pe_samples/PROD0_posterior_samples.hdf5. This is labelled `PhenomPNRT-LS` in the PESummary metafile. To perform the review tasks, we are using the sample release associated with GW190425. The PESummary metafile containing results can be found here: https://dcc.ligo.org/public/0165/P2000026/001/GW190425_posterior_samples.h5. For comparisons to lalinference, we use the PROD0 run: https://git.ligo.org/pe/O3/S190425z/-/blob/master/pe_samples/PROD0_posterior_samples.hdf5. This is labelled `PhenomPNRT-LS` in the PESummary metafile.
\ No newline at end of file
# `pesummary`: [0.4.0](https://git.ligo.org/lscsoft/pesummary/-/tree/v0.4.0) review
## Links to tests
> Mark complete with `:white_check_mark:` and incomplete with `:x:`
| Test | Related Resources | Person Responsible | Reviewer | Status | Sign off hash | Final Sign off |
| ---- | ----------------- | ------------------ | -------- | ------ | ------------- | --------------- |
| Non-evolved remnant fits for nonprecessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#non-evolved-nrutils-remnant-fits)| @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | 700ceb82 | :heavy_check_mark: |
| Non-evolved remnant fits for precessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#non-evolved-nrutils-remnant-fits)| @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | [1fb27730](https://git.ligo.org/lscsoft/pesummary/-/tree/1fb27730d11f4557712e5cae365caf2d361fb401) | :heavy_check_mark: |
| Behaviour of evolved remnant fits when applied to nonprecessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#spin-evolution-for-nrutils-fits)| @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :construction: | | |
| Evolved remnant fits for precessing PE runs| [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#spin-evolution-for-nrutils-fits)| @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | [18b79318](https://git.ligo.org/lscsoft/pesummary/-/tree/18b79318f53f66750150b4159c6bf8c427fe37db) | :heavy_check_mark: |
| Surrogate remnant fits for precessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#surrogate-fits) | @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :white_check_mark: | [148b45dc](https://git.ligo.org/lscsoft/pesummary/-/commit/148b45dc323010f597acb7c205aea0030898ccd8) | :heavy_check_mark: |
| SEOBNRv4PHM and IMRPhenomPv3HM remnant fits for precessing PE runs | [Remnant fits](https://git.ligo.org/lscsoft/pesummary/-/wikis/Remnant-fits#seobnrv4phm-and-imrphenompv3hm-fits) | @charlie.hoy | @david-keitel @nathan-johnson-mcdaniel | :construction: | | |
## Review Telecons
\ No newline at end of file