Skip to content

Changes

Page history
Updating with additional comments and signoff authored by Nathan Johnson-McDaniel's avatar Nathan Johnson-McDaniel
Show whitespace changes
Inline Side-by-side
tilts_at_infinity_review.md
View page @ b6dd468e
...@@ -20,12 +20,31 @@ Using the script given below, we find differences of at most `2e-7 rad` in the t ...@@ -20,12 +20,31 @@ Using the script given below, we find differences of at most `2e-7 rad` in the t
### Example output ### Example output
To check that the newly added command line arguments work as expected we have generated 8 webpages using `summarypages`. These webpages test the following situations:
1) no spin evolution is performed when neither the `--evolve_spins_forwards` or `--evolve_spins_backwards` flags are provided, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/no_evolve/home.html)
2) the hybrid-orbit averaged method works as expected, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/hybrid_orbit_averaged/home.html)
3) the precession averaged method works as expected, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/precession_averaged/home.html)
4) forward spin evolution works as expected, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/ISCO/home.html)
5) forward and backward spin evolution can be run simultaneously, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/ISCO_and_precession_averaged/home.html)
6) backward spin evolution is not performed for an aligned-spin system, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/aligned_spin_and_precession_averaged/home.html)
7) backward spin evolution is not performed for result files containing tidal parameters, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/BNS_and_precession_averaged/home.html)
8) backward spin evolution can be performed for result files containing tidal parameters if the `--force_BH_spin_evolution` flag is provided, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/BNS_and_precession_averaged_and_force_spin/home.html)
For details about the command lines that were run please see the `About` page.
### Comments ### Comments
The previous `--evolve_spins` command-line option for evolving the spins forward to the ISCO frequency for remnant fits evaluation has been deprecated and replaced by `--evolve_spins_forward`, for symmetry with the `--evolve_spins_backward` option for the tilts at infinity. There is a message letting the user know about the deprecation of `--evolve_spins` if they use it and what they should use instead. The previous `--evolve_spins` command-line option for evolving the spins forward to the ISCO frequency for remnant fits evaluation has been deprecated and replaced by `--evolve_spins_forward`, for symmetry with the `--evolve_spins_backward` option for the tilts at infinity. There is a message letting the user know about the deprecation of `--evolve_spins` if they use it and what they should use instead.
The evolution to infinity currently does not produce samples at infinity in aligned-spin cases, since the evolution is trivial. However, it could be changed to give the trivial results if this is desired.
There is currently not a regression test for the tilts at infinity in PESummary. Such a test will be added later--it was important to get the basic implementation finalized ASAP for the application to the O3a-final and O3b catalogue papers.
### Signoff ### Signoff
I sign off on this as of commit [05e7d0342f02c56ab5c9ac0802f012d9c90d99ad](https://git.ligo.org/lscsoft/pesummary/-/merge_requests/530/diffs?commit_id=05e7d0342f02c56ab5c9ac0802f012d9c90d99ad) in the merge request. NKJ-M, 19.7.2021
### Comparison script ### Comparison script
``` ```
# Check PESummary output of tilts at infinity # Check PESummary output of tilts at infinity
...@@ -77,15 +96,3 @@ print(max(abs(tilt1_inf - tilt1_inf_check)), max(abs(tilt2_inf - tilt2_inf_check ...@@ -77,15 +96,3 @@ print(max(abs(tilt1_inf - tilt1_inf_check)), max(abs(tilt2_inf - tilt2_inf_check
### `summarypages` implementation ### `summarypages` implementation
To check that the newly added command line arguments work as expected we have generated 8 webpages using `summarypages`. These webpages test the following situations:
1) backward spin evolution is not performed for result files containing tidal parameters, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/BNS_and_precession_averaged/home.html)
2) backward spin evolution can be performed for result files containing tidal parameters if the `--force_BH_spin_evolution` flag is provided, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/BNS_and_precession_averaged_and_force_spin/home.html)
3) forward spin evolution works as expected, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/ISCO/home.html)
4) forward and backward spin evolution can be ran simultaneously, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/ISCO_and_precession_averaged/home.html)
5) backward spin evolution is not performed for an aligned-spin system, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/aligned_spin_and_precession_averaged/home.html)
6) the hybrid-orbit averaged method works as expected, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/hybrid_orbit_averaged/home.html)
7) the precession averaged method works as expected, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/precession_averaged/home.html)
8) no spin evolution is performed when neither the `--evolve_spins_forwards` or `--evolve_spins_backwards` flags are provided, [webpage](https://ldas-jobs.ligo.caltech.edu/~charlie.hoy/projects/pesummary/evolve_to_infinity/no_evolve/home.html)
For details about the command lines that were run please see the `About` page.
\ No newline at end of file