From 7e4ad3931588d832eeb09e1594504285b5d14f66 Mon Sep 17 00:00:00 2001
From: Tanner Prestegard <tanner.prestegard@ligo.org>
Date: Thu, 23 Aug 2018 14:08:19 -0500
Subject: [PATCH] Bugfix to web-based event log creation
Fixed two bugs in web-based event log creation: first, attempts
to save an EventLog with a null filename, and attempted creation
of the 'lvem' tag with the wrong information, possibly resulting in
an IntegrityError due to duplicate tags.
---
gracedb/events/views.py | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/gracedb/events/views.py b/gracedb/events/views.py
index 8f361114b..2d76042b3 100644
--- a/gracedb/events/views.py
+++ b/gracedb/events/views.py
@@ -228,8 +228,8 @@ def logentry(request, event, num=None):
except Exception, e:
return HttpResponseServerError(str(e))
- elog.filename = filename
- elog.file_version = file_version
+ elog.filename = filename
+ elog.file_version = file_version
try:
elog.save()
@@ -269,8 +269,7 @@ def logentry(request, event, num=None):
try:
tag = Tag.objects.get(name=settings.EXTERNAL_ACCESS_TAGNAME)
except:
- displayName = request.POST.get('displayName')
- tag = Tag(name=tagname, displayName=displayName)
+ tag = Tag(name=settings.EXTERNAL_ACCESS_TAGNAME)
tag.save()
# I'm putting this in a try/except in case the user has already
# added the external access tagname somehow, and the following
--
GitLab