Changes

Page history
Update O4 Code Review authored by Mick Wright's avatar Mick Wright
Hide whitespace changes
Inline Side-by-side
O4-Code-Review.md
View page @ 423a610e
...@@ -19,14 +19,14 @@ Note the failure of convergence of the nessai run. These settings have proved to ...@@ -19,14 +19,14 @@ Note the failure of convergence of the nessai run. These settings have proved to
### Micro-Milli Testing Runs ### Micro-Milli Testing Runs
| Run Type | Run Directory | Corner Plot | | Run Type | Run Directory | Corner Plot | Sign-off (Harsh) | Sign-off (Suvodip) |
|----------|---------------|-------------| |----------|---------------|-------------|------------------|--------------------|
| Microlensed GW150914-like as Microlensing | `CIT:/home/mick.wright/gravelamps-o4-review/micro-as-micro` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/micro-as-micro-corner.png) | | Microlensed GW150914-like as Microlensing | `CIT:/home/mick.wright/gravelamps-o4-review/micro-as-micro` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/micro-as-micro-corner.png) | | |
| Microlensed GW150914-like as Millilensing | `CIT:/home/mick.wright/gravelamps-o4-review/micro-as-milli` | [Corner](https://ldas-jobs.ligo.caltech.edu/\~mick.wright/gravelamps-o4-review/micro-as-milli-corner.png) | | Microlensed GW150914-like as Millilensing | `CIT:/home/mick.wright/gravelamps-o4-review/micro-as-milli` | [Corner](https://ldas-jobs.ligo.caltech.edu/\~mick.wright/gravelamps-o4-review/micro-as-milli-corner.png) | | |
| Microlensed GW150914-like as Unlensed | `CIT:/home/mick.wright/gravelamps-o4-review/micro-as-unlensed` | [Corner](https://ldas-jobs.ligo.caltech.edu/\~mick.wright/gravelamps-o4-review/micro-as-unlensed-corner.png) | | Microlensed GW150914-like as Unlensed | `CIT:/home/mick.wright/gravelamps-o4-review/micro-as-unlensed` | [Corner](https://ldas-jobs.ligo.caltech.edu/\~mick.wright/gravelamps-o4-review/micro-as-unlensed-corner.png) | | |
| Millilensed GW150914-like as Microlensing | `CIT:/home/mick.wright/gravelamps-o4-review/milli-as-micro` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/milli-as-micro-corner.png) | | Millilensed GW150914-like as Microlensing | `CIT:/home/mick.wright/gravelamps-o4-review/milli-as-micro` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/milli-as-micro-corner.png) | | |
| Millilensed GW150914-like as Millilensing | `CIT:/home/mick.wright/gravelamps-o4-review/milli-as-milli` | [Corner](https://ldas-jobs.ligo.caltech.edu/\~mick.wright/gravelamps-o4-review/milli-as-milli-corner.png) | | Millilensed GW150914-like as Millilensing | `CIT:/home/mick.wright/gravelamps-o4-review/milli-as-milli` | [Corner](https://ldas-jobs.ligo.caltech.edu/\~mick.wright/gravelamps-o4-review/milli-as-milli-corner.png) | | |
| Millilensed GW150914-like as Unlensed | `CIT:/home/mick.wright/gravelamps-o4-review/milli-as-unlensed` | [Corner](https://ldas-jobs.ligo.caltech.edu/\~mick.wright/gravelamps-o4-review/milli-as-unlensed-corner.png) | | Millilensed GW150914-like as Unlensed | `CIT:/home/mick.wright/gravelamps-o4-review/milli-as-unlensed` | [Corner](https://ldas-jobs.ligo.caltech.edu/\~mick.wright/gravelamps-o4-review/milli-as-unlensed-corner.png) | | |
#### Bayes Factors #### Bayes Factors
...@@ -76,6 +76,11 @@ These runs use the configuration from the microlensing true run with the candida ...@@ -76,6 +76,11 @@ These runs use the configuration from the microlensing true run with the candida
- Corner: [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/dynesty-candidate.png) - Corner: [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/dynesty-candidate.png)
- Parameters recovered as expected - Parameters recovered as expected
Sign offs:
- [ ] Harsh
- [ ] Suvodip
#### Bilby MCMC #### Bilby MCMC
- Run Directory: `UWM:/home/mick.wright/gravlemaps-o4-review/sampler-settings/bilby-mcmc-review-candidate` - Run Directory: `UWM:/home/mick.wright/gravlemaps-o4-review/sampler-settings/bilby-mcmc-review-candidate`
...@@ -90,11 +95,11 @@ These runs use the configuration from the microlensing true run with the candida ...@@ -90,11 +95,11 @@ These runs use the configuration from the microlensing true run with the candida
## Lens Generation ## Lens Generation
| Lens Model | Run Status | Run Directory | Amplification Plot | | Lens Model | Run Status | Run Directory | Amplification Plot | Sign Off (Harsh) | Sign Off (Suvodip) |
| ---------- | ---------- | ------------- | ------------------ | | ---------- | ---------- | ------------- | ------------------ | ---------------- | ------------------ |
| Point | Complete | UWM:`/home/mick.wright/gravelmaps-o4-review/generation-runs/point-generation` | [Plot](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/point-amplification.png) | | Point | Complete | UWM:`/home/mick.wright/gravelmaps-o4-review/generation-runs/point-generation` | [Plot](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/point-amplification.png) | | |
| SIS | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/generation-runs/light-test/sis-generation` | [Plot](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/sis-amplification.png) | | SIS | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/generation-runs/light-test/sis-generation` | [Plot](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/sis-amplification.png) | | |
| NFW | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/generation-runs/light-test/nfw-generation-lighter` | [Plot](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/nfw-amplification.png) | | NFW | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/generation-runs/light-test/nfw-generation-lighter` | [Plot](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/nfw-amplification.png) | | |
NFW feature in y = 0.01 line supported by higher accuracy run NFW feature in y = 0.01 line supported by higher accuracy run
...@@ -102,24 +107,24 @@ NFW feature in y = 0.01 line supported by higher accuracy run ...@@ -102,24 +107,24 @@ NFW feature in y = 0.01 line supported by higher accuracy run
All of these are being performed with the O4 candidate bilby, bilby_pipe, and dynesty and using the above settings for generation/the result files from these for SIS and NFW (to avoid duplication of lengthy work) All of these are being performed with the O4 candidate bilby, bilby_pipe, and dynesty and using the above settings for generation/the result files from these for SIS and NFW (to avoid duplication of lengthy work)
| Run | Status | Directory | Corner | | Run | Status | Directory | Corner | Sign Off (Harsh) | Sign Off (Suvodip) |
| --- | ------ | --------- | ------ | | --- | ------ | --------- | ------ | ---------------- | ------------------ |
| Point as Point | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/point-as-point` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/point-as-point.pdf) | | Point as Point | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/point-as-point` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/point-as-point.pdf) | | |
| Point as SIS | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/point-as-sis` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/point-as-sis.pdf) | | Point as SIS | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/point-as-sis` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/point-as-sis.pdf) | | |
| Point as NFW | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/point-as-nfw` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/point-as-nfw.pdf) | | Point as NFW | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/point-as-nfw` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/point-as-nfw.pdf) | | |
| Point as Unlensed | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/point-as-unlensed` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/point-as-unlensed.pdf) | | Point as Unlensed | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/point-as-unlensed` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/point-as-unlensed.pdf) | | |
| SIS as Point | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/sis-as-point` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/sis-as-point.pdf) | | SIS as Point | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/sis-as-point` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/sis-as-point.pdf) | | |
| SIS as SIS | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/sis-as-sis` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/sis-as-sis.pdf) | | SIS as SIS | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/sis-as-sis` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/sis-as-sis.pdf) | | |
| SIS as NFW | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comaprison/sis-as-nfw` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/sis-as-nfw.pdf) | | SIS as NFW | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comaprison/sis-as-nfw` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/sis-as-nfw.pdf) | | |
| SIS as Unlensed | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/sis-as-unlensed` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/sis-as-unlensed.pdf) | | SIS as Unlensed | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/sis-as-unlensed` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/sis-as-unlensed.pdf) | | |
| NFW as Point | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/nfw-as-point` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/nfw-as-point.pdf) | | NFW as Point | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/nfw-as-point` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/nfw-as-point.pdf) | | |
| NFW as SIS | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/nfw-as-sis` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/nfw-as-sis.pdf) | | NFW as SIS | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/nfw-as-sis` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/nfw-as-sis.pdf) | | |
| NFW as NFW | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/nfw-as-nfw` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/nfw-as-nfw.pdf) | | NFW as NFW | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/nfw-as-nfw` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/nfw-as-nfw.pdf) | | |
| NFW as Unlensed | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/nfw-as-unlensed` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/nfw-as-unlensed.pdf) | | NFW as Unlensed | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/nfw-as-unlensed` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/nfw-as-unlensed.pdf) | | |
| Unlensed as Point | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/unlensed-as-point` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/unlensed-as-point.pdf) | | Unlensed as Point | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/unlensed-as-point` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/unlensed-as-point.pdf) | | |
| Unlensed as SIS | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/unlensed-as-sis` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/unlensed-as-sis.pdf) | | Unlensed as SIS | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/unlensed-as-sis` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/unlensed-as-sis.pdf) | | |
| Unlensed as NFW | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/unlensed-as-nfw` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/unlensed-as-nfw.pdf) | | Unlensed as NFW | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/unlensed-as-nfw` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/unlensed-as-nfw.pdf) | | |
| Unlensed as Unlensed | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/unlensed-as-unlensed` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/unlensed-as-unlensed.pdf) | | Unlensed as Unlensed | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/unlensed-as-unlensed` | [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/corners/unlensed-as-unlensed.pdf) | | |
### Log Bayes Factor Table ### Log Bayes Factor Table
... ...
......