O4-Code-Review.md

@@ -49,16 +49,18 @@ Relatively minor difference between the millilensing and non-lensing as compared
 
 It would seem that the odd plotting behaviour of the combined samples is present in Chain 2, but all chains are in agreement. 
 
-### Millilensing Update Runs
+#### Millilensing update
 
-Runs follow same configuration as previous test case with updated Gravelamps which should hopefully be consistent with the original millilensing pipeline
+After some bugs were identified, a rerun of the millilensing run has yielded the following results
 
-| Run Type | Run Directory | Corner Plot |
-| -------- | ------------- | ----------- |
-| Microlensed GW150914-like as Millilensing | `CIT:/home/mick.wright/gravelamps-o4-review/micro-as-milli2` | |
-| Millilensed GW150914-like as Millilensing | `CIT:/home/mick.wright/gravelamps-o4-review/milli-as-milli2` | |
-| Millilensed GW150914-like as Microlensing | `CIT:/home/mick.wright/gravelamps-o4-review/milli-as-micro2` | |
-| Millilensed GW150914-like as Unlensed | `CIT:/home/mick.wright/gravelamps-o4-review/milli-as-unlensed2` | | 
+- Run Directory: `UWM:/home/mick.wright/gravelamps-o4-review/test-set-rerun/milli-as-milli-update`
+- Status: Complete
+- Corners:
+     - [Continuous Parameters](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/milli-update.png)
+     - [Signal Numbers](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/milli-discrete.png)
+     - [Signal 0 Phase](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/milli-discrete-phase-0.png)
+     - [Signal 1 Phase](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/milli-discrete-phase-1.png)
+- Parameters are largely as expected, signal 1 phase may bear some further investigation since it does not seem to yield confident constraint.
 
 ### Candidate O4 Sampling Review Tests
 
@@ -77,14 +79,40 @@ These runs use the configuration from the microlensing true run with the candida
 #### Bilby MCMC
 
 - Run Directory: `UWM:/home/mick.wright/gravlemaps-o4-review/sampler-settings/bilby-mcmc-review-candidate`
-- Status: Running
+- Status: Complete
+- Corner: [Corner](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/bilby-mcmc-candidate.png)
+- Run did not converge, chains are very inconsistent
 
 #### Nessai
 
+- Run Directory: `UWM:/home/mick.wright/gravelamps-o4-review/sampler-settings/nessai-review-candidate`
+- Status: Setting tweaks ongoing
+
 ## Lens Generation
 
 | Lens Model | Run Status | Run Directory | Amplification Plot |
 | ---------- | ---------- | ------------- | ------------------ |
-| Point | Complete | UWM:`/home/mick.wright/gravelmaps-o4-review/generation-runs/point-generation` | |
-| SIS | Running | UWM:`/home/mick.wright/gravelamps-o4-review/generation-runs/sis-generation` | |
-| NFW | Running | UWM:`/home/mick.wright/gravelamps-o4-review/generation-runs/nfw-generation` | | 
\ No newline at end of file
+| Point | Complete | UWM:`/home/mick.wright/gravelmaps-o4-review/generation-runs/point-generation` | [Plot](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/point-amplification.png) |
+| SIS | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/generation-runs/light-test/sis-generation` | [Plot](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/sis-amplification.png) |
+| NFW | Complete | UWM:`/home/mick.wright/gravelamps-o4-review/generation-runs/light-test/nfw-generation-lighter` | [Plot](https://ldas-jobs.ligo.caltech.edu/~mick.wright/gravelamps-o4-review/nfw-amplification.png) | 
+
+NFW feature in y = 0.01 line supported by higher accuracy run
+
+## Lens Model Selection
+
+All of these are being performed with the O4 candidate bilby, bilby_pipe, and dynesty and using the above settings for generation/the result files from these for SIS and NFW (to avoid duplication of lengthy work)
+
+| Run | Status | Directory | Corner |
+| --- | ------ | --------- | ------ |
+| Point as Point | Running | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/point-as-point` | |
+| Point as SIS | Running | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/point-as-sis` | |
+| Point as NFW | Running | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/point-as-nfw` | |
+| Point as Unlensed | Running | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/point-as-unlensed` | |
+| SIS as Point | Running | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/sis-as-point` | |
+| SIS as SIS | Running | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/sis-as-sis` | |
+| SIS as NFW | Running | UWM:`/home/mick.wright/gravelamps-o4-review/model-comaprison/sis-as-nfw` | |
+| SIS as Unlensed | Running | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/sis-as-unlensed` | |
+| NFW as Point | Running | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/nfw-as-point` | |
+| NFW as SIS | Running | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/nfw-as-sis` | |
+| NFW as NFW | Running | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/nfw-as-nfw` | |
+| NFW as Unlensed | Running | UWM:`/home/mick.wright/gravelamps-o4-review/model-comparison/nfw-as-unlensed` | |