-
Sync recent fixes. Add IMRPhenomX routines to WaveformParams Update in phiRef, not rotate spherical harmonics add some missing doxygen documentation Fix of phi0 by Marta to pass LAL tests Remove rotation from spherical harmonics for the 22 mode Fix phiRef for 22 mode called through PhXHM Adding back the Pi/4 for phi0 Add XLAL functions for amplitude and phase (only higher modes and without multibanding) Remove forgoten debbuging print for the new functions in previous commit Fix compile error. Fix phi0 and phifRef terms. Fix wrong sign. Fix FrequencySequence for XAS and XHM Found bug in IMRPhenomX_Intermediate_Amp_22_vA. Patch to fix bug. Turn off debugging Update on phiRef for XAS and XHM Simplify alignment of the higher modes phases Clean up code and simplify alignment fix typo in phiref assignment Increase f_max to 0.3Mf to allow comparison to PhenomXHM Increase f_max to 0.3Mf to allow comparison to PhenomXHM Bug found in IMRPhenomXHM2 only affecting 32 mode Remove compilation flag for multibanding Add slightly kludge-y fix for time and phase shifts New linb fit for 22 and time shift to peak approx at 0 without manually computing the max in ChooseTD Improved docs about multibanding and mode array for LALInference Fix printf types in debugging mode Set lina = 0, and comments Recycle 22 mode for mixing even if the 2-2 only is called. Comment redundant set of epoch for PXAS. Cosmetics Add modesList and phenomXHMMband options to GenerateSimulation and fix doc strings Typo multibanding doc string for LALInference Remove commented code and add some comments update some phase fits Force peak exactly at zero for time domain Improve doxygen Timeshift of 500M for Fourier domain Fix units in time shift in FD, the epoch is still shifted too. Change implementation of time shifts Update intermediate amplitude higher modes Update spacing merger bin Add PhXHM to Waveform Cache and update comments Fix finite precision issue for ISCO function Tune intermediate amp 32 when RD coll point is too low Correct deltaF for RD bin improve high-spin behaviour of 21 mode Include f_max in the freq array, before it stopped at f_max-df Allow to call XLALSimIMRPhenomXHMMultiBandOneModeMixing with 22 = None/NULL Improve intermediate amplitude 32 mode Handle very short waveforms (without spherical part) for 32 mode and multibanding Set default multiband threshold to 0.001 A bit of docs Don't create 22 mode if 32 mode does not have spheroidal part Forgot to change default mband threshold in some places Use merger bin instead of rd bin when MfLorentzian>Mfmax Introduce switch for linear interpolation of amplitude in MBand Fix coarse deltaF inspiral Add warnings Add warnings to other XLAL function Remove eta < MAX_ALLOWED warning Fix bug deltaF merger bin update fits Set amplitude interpolation to linear by default Comments Jonathan Fix wrong fit in previous commit and a typo Choose between dfphase and dfamp for ringdown bin Correct previous commit Add extra points to coarse grid if lastfreq < Mfmax Add first round of comments more comments, delete obsolete code Previous commit for the mode mixing function too correct wrong mass cutoff to choose colloc pts Adding warning messages to PhenomXHM Roberto's comments code inspection Check that in MB last freq is not higher than Mfmax Define some arrays in MB with LALMalloc Fix bug in 32 reconstruction -- make sure correct derivatives are passed to IR reconstruction Forgot to free memory for the new XLALMalloc definitions Add code to save phase parameters to file in debugging mode Split doxygen documentation over functions Add references to equations in paper draft Add links to papers and review wiki in doxygen docs Support calling negative m for individual modes functions Updating phase fits to new SXS catalog add correction to align peak of strain (and not psi4) at t=0 Updating phase fits to new SXS catalog. Adding IM v3mRDv4. Upper cutoff freq for spins above 0.99, and fix round error in message of q above 1000 Fix error message when q>1000 Fix typo error message Solve merge conflicts Add dcc link to the XHM paper correct higher-modes phase alignment Add links to paper and supplementary material add comments about version flags delete obsolete use of ringdown phase flag update intermediate phase flags update ringdown flags Update ringdown flags amplitude Return offset individual modes functions add arxiv placeholders to LALSimInspiral.h Adding documentation for waveform flags into PhenomX doxygen. Code cleanup. Adding reference placeholders. Recommended flags in error messages. Code cleanup in parts. Add comments on version flags to error messages add last round of error comments (cherry picked from commit f57c060a)
