Skip to content

Changes

Page history
Update Code review authored by ABHIRUP GHOSH's avatar ABHIRUP GHOSH
Show whitespace changes
Inline Side-by-side
Code-review.md
View page @ 6c6a43de
......@@ -2,6 +2,20 @@
# Code Review
## Overall code status
| Code | Status |
|------|--------|
| `lalinference/python/cbcBayesCompPos.py` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/python/cbcBayesPPAnalysis.py` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/python/cbcBayesPostProc.py `|<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/python/lalinference/bayespputils.py` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/src/LALInference.c` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/src/LALInference.h` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/src/LALInferenceInitCBC.c` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/src/LALInferenceProposal.c` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/src/LALInferenceTemplate.c` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
## Build details
| Branch | Git hash | Diff Patch | Build status |
......@@ -181,20 +195,6 @@ Both dQuadMon1 and dQaudMon2 are sampleddQM1: 0.000000e+00, dQM2: -7.584580e+01
* --dQuadMonSA --fix-dQuadMonS 0.0
* --dQuadMon12 --fix-dQuadMon2 0.0
## Overall code status
| Code | Status |
|------|--------|
| `lalinference/python/cbcBayesCompPos.py` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/python/cbcBayesPPAnalysis.py` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/python/cbcBayesPostProc.py `|<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/python/lalinference/bayespputils.py` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/src/LALInference.c` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/src/LALInference.h` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/src/LALInferenceInitCBC.c` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/src/LALInferenceProposal.c` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
| `lalinference/src/LALInferenceTemplate.c` |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/>|
## Notes on the codes
* There seems to be an inconsistency between naming the variables with lower and upper case: "dquadmona" vs "dQuadMon1". The post-processing scripts have lower case, while the sampling scripts have upper case. `Clarify with Krishnendu`.
......