Skip to content

Changes

Page history
Update Code review authored by ABHIRUP GHOSH's avatar ABHIRUP GHOSH
Show whitespace changes
Inline Side-by-side
Code-review.md
View page @ e5e8b351
...@@ -74,17 +74,6 @@ plt.ylabel('$\delta \kappa _A$') ...@@ -74,17 +74,6 @@ plt.ylabel('$\delta \kappa _A$')
### `lalinference/src/LALInferenceInitCBC.c`/`lalinference/src/LALInferenceProposal.c`/`lalinference/src/LALInferenceTemplate.c` ### `lalinference/src/LALInferenceInitCBC.c`/`lalinference/src/LALInferenceProposal.c`/`lalinference/src/LALInferenceTemplate.c`
Different sampling scenarios:
| Sampling case| Options to be passed |
|---|---|
| SA | --dQuadMonSA --dQuadMonS-min WW --dQuadMonS-max XX --dQuadMonA-min YY --dQuadMonA-max ZZ |
| S | --dQuadMonSA --fix-dQuadMonA 0.0 --dQuadMonS-min WW --dQuadMonS-max XX |
| S | --dQuadMonSA --fix-dQuadMonS 0.0 --dQuadMonA-min WW --dQuadMonA-max XX |
| 12 | --dQuadMon12 --dQuadMon1-min WW --dQuadMon1-max XX --dQuadMon2-min YY --dQuadMon2-max ZZ |
| 1 | --dQuadMon12 --fix-dQuadMon2 0.0 --dQuadMon1-min WW --dQuadMon1-max XX |
| 2 | --dQuadMon12 --fix-dQuadMon1 0.0 --dQuadMon2-min WW --dQuadMon2-max XX |
| | Tasks| Status | | | Tasks| Status |
|---|---|---| |---|---|---|
| 1. | Priors on all 4 non-GR parameters |:x:| | 1. | Priors on all 4 non-GR parameters |:x:|
...@@ -96,6 +85,16 @@ Different sampling scenarios: ...@@ -96,6 +85,16 @@ Different sampling scenarios:
| 7. | `fprintf(stdout,"Both dQuadMon1 and dQaudMon2 are sampled");`| :white_check_mark:| | 7. | `fprintf(stdout,"Both dQuadMon1 and dQaudMon2 are sampled");`| :white_check_mark:|
| 8. | `fprintf(stdout,"dQM1: %e, dQM2: %e \n",dQuadMon1,dQuadMon2);` | :white_check_mark: | | 8. | `fprintf(stdout,"dQM1: %e, dQM2: %e \n",dQuadMon1,dQuadMon2);` | :white_check_mark: |
**Different sampling scenarios:**
| Sampling case| Options to be passed |
|---|---|
| SA | --dQuadMonSA --dQuadMonS-min WW --dQuadMonS-max XX --dQuadMonA-min YY --dQuadMonA-max ZZ |
| S | --dQuadMonSA --fix-dQuadMonA 0.0 --dQuadMonS-min WW --dQuadMonS-max XX |
| S | --dQuadMonSA --fix-dQuadMonS 0.0 --dQuadMonA-min WW --dQuadMonA-max XX |
| 12 | --dQuadMon12 --dQuadMon1-min WW --dQuadMon1-max XX --dQuadMon2-min YY --dQuadMon2-max ZZ |
| 1 | --dQuadMon12 --fix-dQuadMon2 0.0 --dQuadMon1-min WW --dQuadMon1-max XX |
| 2 | --dQuadMon12 --fix-dQuadMon1 0.0 --dQuadMon2-min WW --dQuadMon2-max XX |
Reference Injection file: [S190814bv.xml](uploads/1e189529dbc83ded65aac7a1bfca84a2/S190814bv.xml) Reference Injection file: [S190814bv.xml](uploads/1e189529dbc83ded65aac7a1bfca84a2/S190814bv.xml)
......