Skip to content

Changes

Page history
Update Code review authored by ABHIRUP GHOSH's avatar ABHIRUP GHOSH
Show whitespace changes
Inline Side-by-side
Code-review.md
View page @ ed6d806d
......@@ -29,27 +29,27 @@
| Tasks| Status |
|---|---|
| Comparison of GR case between master and feature branch | |
| Comparison of all 4 non-GR cases | |
| Comparison of GR case between master and feature branch |:x: |
| Comparison of all 4 non-GR cases |:x: |
### `lalinference/python/cbcBayesPPAnalysis.py`
| Tasks| Status |
|---|---|
| Cases that cover all 4 non-GR parameters | |
| Cases that cover all 4 non-GR parameters |:x: |
### `lalinference/python/cbcBayesPostProc.py` and `lalinference/python/lalinference/bayespputils.py`
| Tasks| Status |
|---|---|
| Posteriors on all 4 non-GR parameters | |
| Priors on all 4 non-GR parameters | |
| Posteriors on all 4 non-GR parameters |:x: |
| Priors on all 4 non-GR parameters |:x: |
### `lalinference/src/LALInference.c` and `lalinference/src/LALInference.h`
| Tasks| Status |
|---|---|
| Output of `LALInferencedQuadMonSdQuadMonA` function| |
| Output of `LALInferencedQuadMonSdQuadMonA` function|:x: |
We use the following python script to check the output of the `LALInferencedQuadMonSdQuadMonA` function. We generate samples from a distribution uniform in dQuadMonS and dQuadMonA, and plot the scatter of the corresponding dQuadMon1, dQuadMon2 values.
......@@ -87,14 +87,14 @@ Different sampling scenarios:
| | Tasks| Status |
|---|---|---|
| 1. | Priors on all 4 non-GR parameters |<img src="uploads/8cd7d9bfe07d3210bd356ce21e5c6d42/ongoing.png" alt="done" width="80"/> |
| 2. | fix-params should fix the posterior at tmp-value | |
| 3. | `fprintf(stdout,"Both options (from 12 and SA) are given . . Exiting . .\n");` | <img src="uploads/3f6cffbd85ab14f6aa434feecf61b1bd/done.png" alt="done" width="80"/> |
| 4. | `fprintf(stdout,"Only one option (from 12 and SA) is given . . Working fine . .\n");` | <img src="uploads/3f6cffbd85ab14f6aa434feecf61b1bd/done.png" alt="done" width="80"/> |
| 5. | `fprintf(stdout,"Both dQuadMonS and dQaudMonA are sampled");` | <img src="uploads/3f6cffbd85ab14f6aa434feecf61b1bd/done.png" alt="done" width="80"/> |
| 6. | `fprintf(stdout,"dQM1: %e, dQM2: %e, dQMS: %e, dQMA: %e \n",dQuadMon1,dQuadMon2,dQuadMonS,dQuadMonA);`| <img src="uploads/3f6cffbd85ab14f6aa434feecf61b1bd/done.png" alt="done" width="80"/> |
| 7. | `fprintf(stdout,"Both dQuadMon1 and dQaudMon2 are sampled");`| <img src="uploads/3f6cffbd85ab14f6aa434feecf61b1bd/done.png" alt="done" width="80"/>|
| 8. | `fprintf(stdout,"dQM1: %e, dQM2: %e \n",dQuadMon1,dQuadMon2);` | <img src="uploads/3f6cffbd85ab14f6aa434feecf61b1bd/done.png" alt="done" width="80"/> |
| 1. | Priors on all 4 non-GR parameters |:x:|
| 2. | fix-params should fix the posterior at tmp-value |:x: |
| 3. | `fprintf(stdout,"Both options (from 12 and SA) are given . . Exiting . .\n");` | :white_check_mark: |
| 4. | `fprintf(stdout,"Only one option (from 12 and SA) is given . . Working fine . .\n");` | :white_check_mark:|
| 5. | `fprintf(stdout,"Both dQuadMonS and dQaudMonA are sampled");` | :white_check_mark: |
| 6. | `fprintf(stdout,"dQM1: %e, dQM2: %e, dQMS: %e, dQMA: %e \n",dQuadMon1,dQuadMon2,dQuadMonS,dQuadMonA);`| :white_check_mark: |
| 7. | `fprintf(stdout,"Both dQuadMon1 and dQaudMon2 are sampled");`| :white_check_mark:|
| 8. | `fprintf(stdout,"dQM1: %e, dQM2: %e \n",dQuadMon1,dQuadMon2);` | :white_check_mark: |
Reference Injection file: [S190814bv.xml](uploads/1e189529dbc83ded65aac7a1bfca84a2/S190814bv.xml)
......