... | @@ -70,6 +70,7 @@ To check the readiness of this pipeline for the analysis of O3 events. |
... | @@ -70,6 +70,7 @@ To check the readiness of this pipeline for the analysis of O3 events. |
|
|[cbcBayesCompPos.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesCompPos.py) | [L59](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesCompPos.py#L59) and [L71](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesCompPos.py#L71)| `paramNameLatexMap` (convert parameter names to Latex), we define dQuadMon parameter as \delta\kappa <br> added to `clTableParams` (this is to add to the table of confidence levels)| Abhirup & Anuradha G. |**Gupta**: Just \kappa_s is defined here, why not \kappa_1, \kappa_2, \kappa_a as in bayespputils.py? <br> **Abhirup**: Same question as Anuradha. <br> **Krishnnendu**: <br> 1. All the four parameters are added. <br> **new comments** <br> **Gupta:** looks good. | -------- |
|
|
|[cbcBayesCompPos.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesCompPos.py) | [L59](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesCompPos.py#L59) and [L71](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesCompPos.py#L71)| `paramNameLatexMap` (convert parameter names to Latex), we define dQuadMon parameter as \delta\kappa <br> added to `clTableParams` (this is to add to the table of confidence levels)| Abhirup & Anuradha G. |**Gupta**: Just \kappa_s is defined here, why not \kappa_1, \kappa_2, \kappa_a as in bayespputils.py? <br> **Abhirup**: Same question as Anuradha. <br> **Krishnnendu**: <br> 1. All the four parameters are added. <br> **new comments** <br> **Gupta:** looks good. | -------- |
|
|
|[cbcBayesPPAnalysis.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesPPAnalysis.py) | [L88](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesPPAnalysis.py#L88)|Added all four parameters to the list of `posterior_name_to_latex_name` | Abhirup & Anuradha G.|**Gupta**: \kappa_1 and \kappa_2 are also defined here but not \kappa_a. Is this because \kappa_a is always zero in your implimentation? But \kappa_a is defined in bayespputils.py, why? Also, there is a typo, dquadmon2-->dquadmon1. <br> **Abhirup**: Following up on Anuradha's comment, it would be good to keep the implementation as generalised as possible, which means, adding all four parameters in the post-processing codes, wherever possible. <br> **Krishnnendu**: <br> 1. All the four dQuadMon parameters are added and typos are fixed. <br> **new comments** <br> **Gupta:** looks good.| -------- |
|
|
|[cbcBayesPPAnalysis.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesPPAnalysis.py) | [L88](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesPPAnalysis.py#L88)|Added all four parameters to the list of `posterior_name_to_latex_name` | Abhirup & Anuradha G.|**Gupta**: \kappa_1 and \kappa_2 are also defined here but not \kappa_a. Is this because \kappa_a is always zero in your implimentation? But \kappa_a is defined in bayespputils.py, why? Also, there is a typo, dquadmon2-->dquadmon1. <br> **Abhirup**: Following up on Anuradha's comment, it would be good to keep the implementation as generalised as possible, which means, adding all four parameters in the post-processing codes, wherever possible. <br> **Krishnnendu**: <br> 1. All the four dQuadMon parameters are added and typos are fixed. <br> **new comments** <br> **Gupta:** looks good.| -------- |
|
|
|[bayespputils.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py) | [L148](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py#L148) and [L484](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py#L484)| Created a list `spin_induced_quad_terms` and added this to `strongFieldParams` <br> Created corresponding plot labels inside `plot_label(param)` |Abhirup & Anuradha G. |**Gupta**: looks good. <br> **Abhirup**: looks good. <br> **new comments** <br> **Gupta:** fix the typo: in spin_induced_quad_terms 'dquadmona' appears twice. <br> 99bcd8666d6e279ebcad988219ba56c4e70cef50 <br> **Gupta:** Why 'param in eosParams' showing up in your commit? | -------- |
|
|
|[bayespputils.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py) | [L148](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py#L148) and [L484](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py#L484)| Created a list `spin_induced_quad_terms` and added this to `strongFieldParams` <br> Created corresponding plot labels inside `plot_label(param)` |Abhirup & Anuradha G. |**Gupta**: looks good. <br> **Abhirup**: looks good. <br> **new comments** <br> **Gupta:** fix the typo: in spin_induced_quad_terms 'dquadmona' appears twice. <br> 99bcd8666d6e279ebcad988219ba56c4e70cef50 <br> **Gupta:** Why 'param in eosParams' showing up in your commit? | -------- |
|
|
|
|
|[cbcBayesPostProc.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/cbcBayesPostProc.py) | [L1167](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesPostProc.py#L1167)| Using the spin-induced quadrupole moment parameters defined in `lalinference.bayespputils` |Abhirup & Anuradha G. |**Gupta**: <br> **Abhirup**: | -------- |
|
|
|
|
|
|
## A detailed summary of revisions made to the review branch:
|
|
## A detailed summary of revisions made to the review branch:
|
|
- Commit-3: git hash: 08e05a526d3e2bca780bf4fa08fa83df85209d51. Separated the dQuadMon params from the testing GR params. Sampling options now allowd are; for the one parameter case any of the four parameters cane be sampled (one has to fix the other parameter using fix-parameters). <br> For the two parameter case, either {dQuadMon1, dQuadMon2} or {dQuadMonS, dQuadMonA}. <br> If one passes more than two parameters, the run will end with a exist message. Default prior on these parameters will be [-200, 200].
|
|
- Commit-3: git hash: 08e05a526d3e2bca780bf4fa08fa83df85209d51. Separated the dQuadMon params from the testing GR params. Sampling options now allowd are; for the one parameter case any of the four parameters cane be sampled (one has to fix the other parameter using fix-parameters). <br> For the two parameter case, either {dQuadMon1, dQuadMon2} or {dQuadMonS, dQuadMonA}. <br> If one passes more than two parameters, the run will end with a exist message. Default prior on these parameters will be [-200, 200].
|
... | | ... | |