... | ... | @@ -25,12 +25,12 @@ |
|
|
|
|
|
# Review committee
|
|
|
|
|
|
- Review Chair: Add
|
|
|
- Review Chair: Anuradha Gupta
|
|
|
- Reviewers:
|
|
|
- Abhirup
|
|
|
- Anuradha
|
|
|
- Reviewees:
|
|
|
- N V Krishnendu
|
|
|
- Krishnendu
|
|
|
- Saleem
|
|
|
- Anuradha Samajdar
|
|
|
- Chandra
|
... | ... | @@ -46,6 +46,21 @@ |
|
|
|
|
|
[review-statement](Review Statement)
|
|
|
|
|
|
# Detail of the modifications
|
|
|
|
|
|
| Files modified |Lines changed| Short explanation | Person Responsible | Outcome |
|
|
|
| -------- | --- | ----- | -------- | -------- |
|
|
|
|[LALInference.c](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/src/LALInference.c) | [L2322](https://git.ligo.org/nv.krishnendu/lalsuite/blob/eb5f2658c960ad689625c66c7df9e9373a4a27d6/lalinference/src/LALInference.c#L2322)| Function to calculate dQuadMonS and dQuadMonA from dQaudMon1 and dQuadMon2| | |
|
|
|
|[LALInference.h](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/src/LALInference.h) | [L882](https://git.ligo.org/nv.krishnendu/lalsuite/blob/eb5f2658c960ad689625c66c7df9e9373a4a27d6/lalinference/src/LALInference.h#L882)| Function to calculate dQuadMonS and dQuadMonA from dQaudMon1 and dQuadMon2| | |
|
|
|
|[LALInferenceTemplate.c](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/src/LALInferenceTemplate.c) | [L74](https://git.ligo.org/nv.krishnendu/lalsuite/blob/eb5f2658c960ad689625c66c7df9e9373a4a27d6/lalinference/src/LALInferenceTemplate.c#L74) [L76](https://git.ligo.org/nv.krishnendu/lalsuite/blob/eb5f2658c960ad689625c66c7df9e9373a4a27d6/lalinference/src/LALInferenceTemplate.c#L76)| Adding extra params for sampling | | |
|
|
|
|[LALInferenceTemplate.c](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/src/LALInferenceTemplate.c) |[L358](https://git.ligo.org/nv.krishnendu/lalsuite/blob/eb5f2658c960ad689625c66c7df9e9373a4a27d6/lalinference/src/LALInferenceTemplate.c#L358) [L825](https://git.ligo.org/nv.krishnendu/lalsuite/blob/eb5f2658c960ad689625c66c7df9e9373a4a27d6/lalinference/src/LALInferenceTemplate.c#L825) [L1397](https://git.ligo.org/nv.krishnendu/lalsuite/blob/eb5f2658c960ad689625c66c7df9e9373a4a27d6/lalinference/src/LALInferenceTemplate.c#L1397)| Sampling is done on dQuadMonS keeping dQuadMonA to zero| | |
|
|
|
|[LALInferenceInitCBC.c](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/src/LALInferenceInitCBC.c) | [L2176](https://git.ligo.org/nv.krishnendu/lalsuite/blob/eb5f2658c960ad689625c66c7df9e9373a4a27d6/lalinference/src/LALInferenceInitCBC.c#L2176)| Function to calculate dQuadMonS and dQuadMonA from dQaudMon1 and dQuadMon2| | |
|
|
|
|[cbcBayesCompPos.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/a2e4c5f6f10125ae63bd70cf9e7701cc6700cf96/lalinference/python/cbcBayesCompPos.py) | [L59](https://git.ligo.org/nv.krishnendu/lalsuite/blob/a2e4c5f6f10125ae63bd70cf9e7701cc6700cf96/lalinference/python/cbcBayesCompPos.py#L59) [L71](https://git.ligo.org/nv.krishnendu/lalsuite/blob/a2e4c5f6f10125ae63bd70cf9e7701cc6700cf96/lalinference/python/cbcBayesCompPos.py#L71)| | | |
|
|
|
|[cbcBayesPPAnalysis.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/a2e4c5f6f10125ae63bd70cf9e7701cc6700cf96/lalinference/python/cbcBayesPPAnalysis.py) | [L88](https://git.ligo.org/nv.krishnendu/lalsuite/blob/a2e4c5f6f10125ae63bd70cf9e7701cc6700cf96/lalinference/python/cbcBayesPPAnalysis.py#L88)| | | |
|
|
|
|[bayespputils.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/a2e4c5f6f10125ae63bd70cf9e7701cc6700cf96/lalinference/python/lalinference/bayespputils.py) | [L148](https://git.ligo.org/nv.krishnendu/lalsuite/blob/a2e4c5f6f10125ae63bd70cf9e7701cc6700cf96/lalinference/python/lalinference/bayespputils.py#L148) [L484](https://git.ligo.org/nv.krishnendu/lalsuite/blob/a2e4c5f6f10125ae63bd70cf9e7701cc6700cf96/lalinference/python/lalinference/bayespputils.py#L484)| | | |
|
|
|
|
|
|
|
|
|
|
|
|
# Tasks/tests to be accomplished
|
|
|
|
|
|
> Mark complete with `:heavy_check_mark:` and incomplete with `:x:`
|
... | ... | |