Update Home authored by NV Krishnendu's avatar NV Krishnendu
......@@ -54,9 +54,7 @@ To check the readiness of this pipeline for the analysis of O3 events.
# Detail of the modifications
- Git hash of the branch to be reviewed: 5157eea61128250568beca71edbc18c165a4a45e
> This for the first review meeting on 24/05/2019, 07/06/2019 and 21/06/2019. The modifications suggested by the reviewers are in this commit:
- Git hash of the branch to be reviewed: 5157eea61128250568beca71edbc18c165a4a45e
| Files modified |Lines changed| Short explanation | Person Responsible | Reviewer Response | Addressing Issue (if any) |
| -------- | --- | ----- | -------- | -------- | -------- |
......@@ -69,6 +67,9 @@ To check the readiness of this pipeline for the analysis of O3 events.
|[cbcBayesPPAnalysis.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesPPAnalysis.py) | [L88](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/cbcBayesPPAnalysis.py#L88)|Added all four parameters to the list of `posterior_name_to_latex_name` | Abhirup & Anuradha G.|**Gupta**: \kappa_1 and \kappa_2 are also defined here but not \kappa_a. Is this because \kappa_a is always zero in your implimentation? But \kappa_a is defined in bayespputils.py, why? Also, there is a typo, dquadmon2-->dquadmon1. <br> **Abhirup**: Following up on Anuradha's comment, it would be good to keep the implementation as generalised as possible, which means, adding all four parameters in the post-processing codes, wherever possible. <br> **Krishnnendu**: <br> 1. All the four dQuadMon parameters are added and typos are fixed. | -------- |
|[bayespputils.py](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py) | [L148](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py#L148) and [L484](https://git.ligo.org/nv.krishnendu/lalsuite/blob/Ks_21March2019/lalinference/python/lalinference/bayespputils.py#L484)| Created a list `spin_induced_quad_terms` and added this to `strongFieldParams` <br> Created corresponding plot labels inside `plot_label(param)` |Abhirup & Anuradha G. |**Gupta**: looks good. <br> **Abhirup**: looks good.| -------- |
- A detailed summary of revisions made to the review branch:
<br> **Commit-1**
# Tasks/tests to be accomplished
......
......