**Attendance:** Abhirup, Anuradha Samajdar, Anuradha Gupta, Arun, Chandra, Nathan, Krishnendu, Saleem **Action items:** - Abhirup: Look into if statements of lalinference/src/LALInferenceTemplate.c - Abhirup: Add comments on the code to the git record - Krisnendu and Saleem: Generalise code to 4-parameter structure - Krisnendu and Saleem: Generalise priors to include gravastar scenarios - Krisnendu and Saleem: Include an error message if more than 2 of the 4 parameters are specified to sample over **Minutes:** - Code currently sampling over kappa_s, while fixing kappa_a. Discussion over generalising the code and then holding parameters during recovery, if required. - Action items will be taken care of, and there will be another code review call before deciding PE cases. - Next meeting on 2PM UTC, 14th June 2019. ``` <15:01:28> "Krishnendu": Git repo: https://git.ligo.org/nv.krishnendu/lalsuite/wikis/Home <15:02:57> "Abhirup Ghosh [h]": FYI, I could build the branch without any problem <15:05:15> "Abhirup Ghosh [h]": i did not understand this <15:06:05> "Krishnendu": Yes <15:06:52> "chandra": what are those context? is there a simpler answer? <15:07:29> "Saleem": @ Chandra , I was commenting in general, will look into and get back <15:09:09> "Anuradha Gupta": I forgot to mention in th ebegining: anybody up to minutes? <15:10:04> "Abhirup Ghosh [h]": okay. <15:10:25> "Abhirup Ghosh [h]": hand up <15:11:53> "Abhirup Ghosh [h]": i can take minutes <15:11:55> "Saleem": I can <15:11:59> "Saleem": okay <15:12:13> "Saleem": Abhirup go ahead <15:12:20> "chandra": hand up <15:12:49> "Abhirup Ghosh [h]": wait. which comment is this? <15:13:02> "Abhirup Ghosh [h]": can we finish the earlier discussion first. <15:15:17> "K G Arun": hand up <15:16:52> "Abhirup Ghosh [h]": hand up <15:17:40> "K G Arun": I completely agree with Abhirup. <15:17:48> "Saleem": hand up <15:17:56> "Anuradha Gupta": +1 Abhirup <15:18:35> "Krishnendu": That we have already done. <15:18:46> "Abhirup Ghosh [h]": you could just use --fix-param <15:18:54> "Krishnendu": Yea, true. <15:20:24> "Saleem": hand up (reply toAbhirup) <15:20:43> "Abhirup Ghosh [h]": could you take this up as an action item then? <15:20:50> "Krishnendu": Sure <15:21:44> "Krishnendu": So, can I modify the same branch? <15:21:58> "Abhirup Ghosh [h]": i agree. i had a point there. <15:24:17> "Anuradha Gupta": yeah, sure <15:26:25> "Krishnendu": Yes <15:27:52> "Saleem": I think we don't need Kappa1 and kappa2 sampling option since they can be derived from others <15:30:14> "K G Arun": hand up <15:31:14> "Krishnendu": Okay <15:31:33> "Saleem": But there is case of sampling 4 at a time <15:31:40> "K G Arun": Yes. <15:31:49> "Saleem": * there is no case of <15:32:59> "Krishnendu": Hand up <15:33:00> "Anuradha Gupta": hand up <15:33:31> "chandra": hand up <15:34:48> "Krishnendu": Yes <15:34:52> "Abhirup Ghosh [h]": okay. then i am happy. <15:34:55> "chandra": hand down <15:35:27> "Abhirup Ghosh [h]": hand up. <15:37:26> "Anuradha Gupta": hand up <15:37:43> "Abhirup Ghosh [h]": exactly <15:37:55> "Saleem": agree <15:37:57> "Nathan Johnson-McDaniel": Presumably something like this must already be done for the tidal parameters. <15:38:08> "A. Samajdar": sorry i got a bit distracted but I think we can just put an XLAL_WARNING at the lalinference level in the InitCBC file for instance <15:38:44> "Abhirup Ghosh [h]": be careful with the error code, such that the code does not crash but rather just jumps over the crashed point <15:38:49> "Abhirup Ghosh [h]": EDOM vs EFUNC <15:39:07> "chandra": moreover is it the case now? <15:39:21> "chandra": sampling over kappa_s only? <15:39:27> "Abhirup Ghosh [h]": hand up <15:39:43> "Krishnendu": hand up <15:39:58> "K G Arun": ok <15:40:16> "Abhirup Ghosh [h]": sampling over Ks, not Ka <15:40:30> "chandra": okay <15:40:51> "Krishnendu": hand down <15:41:48> "Abhirup Ghosh [h]": yes, i have <15:42:49> "chandra": yes <15:43:46> "K G Arun": yes <15:44:02> "Krishnendu": No <15:44:55> "A. Samajdar": i have to leave now, sorry about that. thanks all. <15:45:01> "Krishnendu": Yes <15:45:12> "Krishnendu": True <15:48:01> "Krishnendu": Okay, I see. <15:49:45> "Krishnendu": Ok, fine. <15:50:02> "Krishnendu": I will do this change. <15:50:15> "Krishnendu": True <15:50:17> "Anuradha Gupta": hand up <15:54:33> "Krishnendu": Sure <15:55:24> "Krishnendu": I can add that. <15:55:29> "Krishnendu": Yes, that is true <15:56:13> "Krishnendu": Okay. <15:56:20> "Abhirup Ghosh [h]": no <15:56:29> "Abhirup Ghosh [h]": i think they are fine <15:57:12> "Abhirup Ghosh [h]": yes. <15:57:21> "Krishnendu": I think it is fine. <15:57:50> "Krishnendu": Okay, thank you! <15:57:54> "Saleem": thanks <15:57:54> "K G Arun": Thanks a lot! Bye! <15:57:57> "chandra": thanks, bye <15:58:00> "Abhirup Ghosh [h]": bye! <15:58:00> "Nathan Johnson-McDaniel": Bye! ```