Skip to content

Changes

Page history
Update Reviewer Notes authored by ABHIRUP GHOSH's avatar ABHIRUP GHOSH
Show whitespace changes
Inline Side-by-side
Reviewer-Notes.md
View page @ 382d6c58
......@@ -106,7 +106,7 @@ XLAL Error - LALInferenceInitCBCModel (LALInferenceInitCBC.c:1451): Invalid argu
Segmentation fault: 11
```
### Task 4
### Task 4-8
**--dQuadMon12**
......@@ -159,9 +159,31 @@ Both dQuadMonS and dQaudMonA are sampleddQM1: -1.611303e+02, dQM2: -2.091703e+0
Both dQuadMonS and dQaudMonA are sampleddQM1: -3.042310e+01, dQM2: 1.218623e+01, dQMS: -9.118437e+00, dQMA: -2.130467e+01
```
| Tasks| Status |
|---|---|
| `fprintf(stdout,"Only one option (from 12 and SA) is given . . Working fine . .\n");` | |
### Comments:
* Ask about new line character.
* The case where we fix one of the parameters, does indeed print fixed values for that parameter during the sampling.
```
lalinference_nest --L1-flow 20 --approx IMRPhenomPv2threePointFivePN --psdlength 492.0 --V1-timeslide 0 --V1-cache LALSimAdVirgo --chirpmass-max 9.519249 --nlive 1024 --inj S190814bv.xml --comp-max 54.40873232560802 --adapt-temps --srate 4096.0 --event 0 --H1-timeslide 0 --V1-fhigh 135.811 --neff 1000 --seglen 16.0 --L1-channel L1:LDAS-STRAIN --L1-fhigh 135.811 --stance-max 500 --0noise --trigtime 900000000 --tol 1.0 --psdstart 899999474.0 --H1-cache LALSimAdLIGO --progress --tolerance 0.1 --H1-channel H1:LDAS-STRAIN --V1-channel V1:h_16384Hz --comp-min 1.6378358668107575 --resume --V1-flow 20 --fref 20 --outfile lalinferencenest-0-V1H1L1-900000000.0-0.hdf5 --L1-cache LALSimAdLIGO --randomseed 1732024500 --dataseed 3000 --L1-timeslide 0 --q-min 0.055728090000841224 --chirpmass-min 5.141979 --H1-flow 20 --H1-fhigh 135.11 --ifo V1 --ifo H1 --ifo L1 --dQuadMon12 --fix-dQuadMon1 0.0
Read end time 900000000.000000
Using detector-based sky frame
Only one option (from 12 and SA) is given . . Working fine . .
--- ---
Templates will run with precessing spins
Templates will run using Approximant 72 (IMRPhenomPv2), phase order 7, amp order -1, spin order -1 tidal order -1 in the frequency domain.
--- ---
Template function called is "LALInferenceTemplateXLALSimInspiralChooseWaveform"
set tolerance.
Sprinkling 1024 live points, may take some time
Both dQuadMon1 and dQaudMon2 are sampleddQM1: 0.000000e+00, dQM2: -1.259211e+02
Both dQuadMon1 and dQaudMon2 are sampleddQM1: 0.000000e+00, dQM2: -4.098038e+01
Both dQuadMon1 and dQaudMon2 are sampleddQM1: 0.000000e+00, dQM2: -7.584580e+01
```
## Overall code status
......