Update Reviewer Notes authored by ABHIRUP GHOSH's avatar ABHIRUP GHOSH
...@@ -41,6 +41,12 @@ The overall plan for this review is here: ...@@ -41,6 +41,12 @@ The overall plan for this review is here:
### `lalinference/src/LALInference.c` and `lalinference/src/LALInference.h` ### `lalinference/src/LALInference.c` and `lalinference/src/LALInference.h`
| Tasks| Status |
|---|---|
| Output of `LALInferencedQuadMonSdQuadMonA` function| |
We use the following python script to check the output of the `LALInferencedQuadMonSdQuadMonA` function. We generate samples from a distribution uniform in dQuadMonS and dQuadMonA, and plot the scatter of the corresponding dQuadMon1, dQuadMon2 values.
``` ```
dQuadMonS = np.random.uniform(-200,200,10000) dQuadMonS = np.random.uniform(-200,200,10000)
dQuadMonA = np.random.uniform(-200,200,10000) dQuadMonA = np.random.uniform(-200,200,10000)
...@@ -60,6 +66,19 @@ plt.ylabel('$\delta \kappa _A$') ...@@ -60,6 +66,19 @@ plt.ylabel('$\delta \kappa _A$')
``` ```
![download](uploads/be779d3e2272a0e6737d4233d7cca2e8/download.png) ![download](uploads/be779d3e2272a0e6737d4233d7cca2e8/download.png)
### `lalinference/src/LALInferenceInitCBC.c` and lalinference/src/LALInferenceProposal.c
| Tasks| Status |
|---|---|
| Priors on all 4 non-GR parameters | |
| fix-params should fix the posterior at tmp-value | |
| `fprintf(stdout,"Only one option (from 12 and SA) is given . . Working fine . .\n");` | |
### `lalinference/src/LALInferenceTemplate.c`
| Code | Test | Status | | Code | Test | Status |
|------|------|--------| |------|------|--------|
| `lalinference/python/cbcBayesCompPos.py` | 1. | | | `lalinference/python/cbcBayesCompPos.py` | 1. | |
... ...
......