Skip to content

Changes

Page history
Update Reviewer Notes authored by ABHIRUP GHOSH's avatar ABHIRUP GHOSH
Show whitespace changes
Inline Side-by-side
Reviewer-Notes.md
View page @ f3ce2f9c
......@@ -66,15 +66,28 @@ plt.ylabel('$\delta \kappa _A$')
```
![download](uploads/be779d3e2272a0e6737d4233d7cca2e8/download.png)
### `lalinference/src/LALInferenceInitCBC.c` and `lalinference/src/LALInferenceProposal.c`
### `lalinference/src/LALInferenceInitCBC.c`
Different sampling scenarios:
| SA | --dQuadMonSA --dQuadMonS-min WW --dQuadMonS-max XX --dQuadMonA-min YY --dQuadMonA-max ZZ |
| S | --dQuadMonSA --fix-dQuadMonA 0.0 --dQuadMonS-min WW --dQuadMonS-max XX |
| S | --dQuadMonSA --fix-dQuadMonS 0.0 --dQuadMonA-min WW --dQuadMonA-max XX |
| 12 | --dQuadMon12 --dQuadMon1-min WW --dQuadMon1-max XX --dQuadMon2-min YY --dQuadMon2-max ZZ |
| 1 | --dQuadMon12 --fix-dQuadMon2 0.0 --dQuadMon1-min WW --dQuadMon1-max XX |
| 2 | --dQuadMon12 --fix-dQuadMon1 0.0 --dQuadMon2-min WW --dQuadMon2-max XX |
| | Tasks| Status |
|---|---|---|
| 1. | Priors on all 4 non-GR parameters | |
| 2. | fix-params should fix the posterior at tmp-value | |
| 3. | `fprintf(stdout,"Both options (from 12 and SA) are given . . Exiting . .\n");` | |
| 4. | `fprintf(stdout,"Only one option (from 12 and SA) is given . . Working fine . .\n");` | |
| Tasks| Status |
|---|---|
| Priors on all 4 non-GR parameters | |
| fix-params should fix the posterior at tmp-value | |
| `fprintf(stdout,"Both options (from 12 and SA) are given . . Exiting . .\n");` ||
| `fprintf(stdout,"Only one option (from 12 and SA) is given . . Working fine . .\n");` | |
### `lalinference/src/LALInferenceProposal.c`
### `lalinference/src/LALInferenceTemplate.c`
| Tasks| Status |
......