Missing install_requires on healpy, ligo.skymap, python-ligo-lw
The package metadata declares the following requirements:
install_requires = [
"h5py",
"lalsuite",
"lscsoft-glue",
"matplotlib",
"numpy",
"scikit-learn",
"scipy",
"six",
]
However, by inspecting the various imports, I see the following requirements:
$ git grep -E -h "^(\s+)?(import|from)" | cut -d\ -f2 | sort -u
.
argparse
ast
bisect
collections
.common_cl
copy
datetime
errno
functools
__future__
glob
glue
glue.lal
h5py
healpy
itertools
json
lal
lalframe.frread
lalinference.rapid_pe
lalinspiral
lalmetaio
lal.rate
lal.series
lalsimulation
ligo.lw
ligo.lw.utils
ligo.skymap.io
math
numpy
os
os,ast
rapid_pe
rapid_pe.common_cl
re
scipy
scipy.linalg
scipy.optimize
scipy.special
select
setuptools
six.moves
sklearn.neighbors
socket
sqlite3
stat
sys
time
types
warnings
Most of these are standard library imports, however I think this exposes missing requirements (not protected by any try/except
) on the following packages:
- healpy
- ligo.skymap
- python-ligo-lw
Should these all be added to install_requires
?
Edited by Duncan Macleod