GstLAL Live Injections will be uploading triggers from all analyses to VTInjection search tag. In order to differentiate them, we would have to parse the labels instead (maybe). Changes might have to be made to allow functioning of the Test Suite
Cort Posnansky (48428bba) at 16 Feb 21:30
This MR allows specifying environment variables in the config as a nice dictionary rather than one big string.
Cort Posnansky (112e64c1) at 16 Feb 21:30
Merge branch 'main-env-handling' into 'main'
... and 1 more commit
Nah it's fine
Ah right, I see. I skimmed this and missed that you are just redefining self.config["condor"]["environment"]
as the string from the dict. So yeah if it's already a string you don't have to do anything and it will get added to the sub as is, not ignored like I originally thought. So that's fine.
Here is an example of both possibilities in a commit I have since squashed in my other MR.
My intention was for my change to add functionality, but not affect existing functionality. The environment could already be specified with a string in the config like environment: '"VAR1=val1 VAR2=val2"'
. If I remove the isinstance
check, then the code will fail if a string is given. As it is now, the "else case" is for my change to not do anything, and the environment line will stay as it is in the config.
To do that, this would have to become a nested if statement instead of one if statement with an "and" in it.
if "environment" in self.config["condor"].keys():
env = self.config["condor"]["environment"]
if isinstance(env, dict)):
env_opts = [f"{key}={val}" for (key, val) in env.items()]
self.config["condor"]["environment"] = f'"{" ".join(env_opts)}"'
Do you prefer that?
Minor point but you could clean up this whole block by defining something like env = self.config["condor"]["environment"]
first so then you don't havee to access this dict more than once
I feel like this extra if isinstance(blah, dict)
should be handled differently. It's kind of leaving open the possibility that this config section might not be a dict, but in that case the code as written would just ignore it. So I think you could make this better in one of two ways:
and isinstance(blah, dict)
and isinstance(blah, dict)
but handle the else
case by attempting to parse the format into the dict that you expectCort Posnansky (48428bba) at 16 Feb 02:26
gw/lts/dags/test_suite_workflow.py: allow env dicts in config
This MR allows specifying environment variables in the config as a nice dictionary rather than one big string.
Cort Posnansky (7b844940) at 14 Feb 15:01
gw/lts/dags/test_suite_workflow.py: allow env dicts in config
Sometimes jobs get stuck for a long time after doing condor_rm. Find which jobs are problematic and diagnose the problem
Create a link from the SNR Recovery Panel on Test Suite Main to a another dashboard which displays results of SNR Recovery based on IFO and Network as well as an option to look at Optimized events
A few final commits before updating to the next major release version.
Rebecca Ewing (3bc80830) at 29 Jan 20:39
bump version to 1.0.0
Rebecca Ewing (5d8a23a9) at 29 Jan 20:38
gw/lts/inspinjmsg_find.py: fix time_ns for terrestrial events
... and 2 more commits
Rebecca Ewing (54b877c6) at 27 Jan 18:48