| ... | @@ -30,8 +30,9 @@ for each component mass, meaning that the total contribution to the weights shou |
... | @@ -30,8 +30,9 @@ for each component mass, meaning that the total contribution to the weights shou |
|
|
|
|
|
|
|
The new version of the code relies on the user to specify the draw probability, so this is rendered moot. Within the tests described below, this was implemented correctly within [this script](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/gw-distributions/test/o3-nsbh/src/convert-event-csv#L48). **Update link once merge request is accepted**
|
|
The new version of the code relies on the user to specify the draw probability, so this is rendered moot. Within the tests described below, this was implemented correctly within [this script](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/gw-distributions/test/o3-nsbh/src/convert-event-csv#L48). **Update link once merge request is accepted**
|
|
|
|
|
|
|
|
- [ ] Reviewer signoff on implementation in example
|
|
- [X] Reviewer signoff on implementation in example
|
|
|
- [ ] Reviewer signoff that in new version of the code, implementation of Jacobians should be done through inputs, not on this code base.
|
|
- [ ] Reviewer signoff that in new version of the code, implementation of Jacobians should be done through inputs, not on this code base.
|
|
|
|
- I cannot yet confirm this because I can't find the `mmms.io` module.
|
|
|
|
|
|
|
|
**bad population reweighing**
|
|
**bad population reweighing**
|
|
|
|
|
|
| ... | | ... | |
