... | @@ -7,6 +7,7 @@ This review certifies that the updated implementation functions as expected (i.e |
... | @@ -7,6 +7,7 @@ This review certifies that the updated implementation functions as expected (i.e |
|
The reviewers sign-off on the following version of the code
|
|
The reviewers sign-off on the following version of the code
|
|
|
|
|
|
* git hash : [d8f97de5d89218f8858ea44d6e8520ea8ca784ca](https://git.ligo.org/reed.essick/mmax-model-selection/-/tree/d8f97de5d89218f8858ea44d6e8520ea8ca784ca)
|
|
* git hash : [d8f97de5d89218f8858ea44d6e8520ea8ca784ca](https://git.ligo.org/reed.essick/mmax-model-selection/-/tree/d8f97de5d89218f8858ea44d6e8520ea8ca784ca)
|
|
|
|
- this is the hash within `master` that resulted from [merging `46f532bc5816909ccf670672c221b2107fd4b9ff`](https://git.ligo.org/reed.essick/mmax-model-selection/-/merge_requests/10) (which Amanda signed off on below)
|
|
|
|
|
|
which relies on standard python libraries (numpy, matplotlib) and
|
|
which relies on standard python libraries (numpy, matplotlib) and
|
|
|
|
|
... | @@ -14,6 +15,8 @@ which relies on standard python libraries (numpy, matplotlib) and |
... | @@ -14,6 +15,8 @@ which relies on standard python libraries (numpy, matplotlib) and |
|
|
|
|
|
I sign off on the current version of the code (46f532bc5816909ccf670672c221b2107fd4b9ff), including commit a9f6a384a2b5cbdbc974c16752465944559f9834 of `gwdistributions`. At this point, all of my suggestions and comments are either for my own understanding or purely cosmetic. The only thing Reed has to do is update git hashes and references to specific lines in the code after he merges !10 - Amanda Farah, 28 August 2023
|
|
I sign off on the current version of the code (46f532bc5816909ccf670672c221b2107fd4b9ff), including commit a9f6a384a2b5cbdbc974c16752465944559f9834 of `gwdistributions`. At this point, all of my suggestions and comments are either for my own understanding or purely cosmetic. The only thing Reed has to do is update git hashes and references to specific lines in the code after he merges !10 - Amanda Farah, 28 August 2023
|
|
|
|
|
|
|
|
This wiki was updated to include the final git hashes and update links to the test results on 29 Aug 2023 (after Amanda signed off on the review). No changes to the code were made.
|
|
|
|
|
|
---
|
|
---
|
|
|
|
|
|
# Review Materials
|
|
# Review Materials
|
... | | ... | |