... | @@ -36,7 +36,7 @@ This review wiki covers the changes to the code based in order to incorporate po |
... | @@ -36,7 +36,7 @@ This review wiki covers the changes to the code based in order to incorporate po |
|
### Additional checklist items for addition of spin inference
|
|
### Additional checklist items for addition of spin inference
|
|
|
|
|
|
* [ ] inference reproduces the same results when spins are neglected (--spin-column is not passed) and when spins are identically zero for all samples
|
|
* [ ] inference reproduces the same results when spins are neglected (--spin-column is not passed) and when spins are identically zero for all samples
|
|
* [ ] inference produces strictly larger estimates for P(m2<Mmax) when spins are included compared to when spins are neglected
|
|
* [ ] inference produces strictly larger estimates for P(m2<Mmax) when spins are included (but known to be less than the break-up spin) compared to when spins are neglected
|
|
* [ ] scaling of Mmax(Mtov, Rtov, spin) was correctly implemented based on Eqn 18 of [Breu+Rezzolla 2016](https://academic.oup.com/mnras/article/459/1/646/2608837).
|
|
* [ ] scaling of Mmax(Mtov, Rtov, spin) was correctly implemented based on Eqn 18 of [Breu+Rezzolla 2016](https://academic.oup.com/mnras/article/459/1/646/2608837).
|
|
* [ ] unit conversion is done correctly within compactness calculation.
|
|
* [ ] unit conversion is done correctly within compactness calculation.
|
|
* [ ] estimate of maximum spin based on (Mtov, Rtov) is correctly implemented based on Eqn 17 of [Breu+Rezzolla 2016](https://academic.oup.com/mnras/article/459/1/646/2608837)
|
|
* [ ] estimate of maximum spin based on (Mtov, Rtov) is correctly implemented based on Eqn 17 of [Breu+Rezzolla 2016](https://academic.oup.com/mnras/article/459/1/646/2608837)
|
... | | ... | |