| ... | @@ -37,9 +37,9 @@ This review wiki covers the changes to the code based in order to incorporate po |
... | @@ -37,9 +37,9 @@ This review wiki covers the changes to the code based in order to incorporate po |
|
|
|
|
|
|
|
* [ ] inference reproduces the same results when spins are neglected (--spin-column is not passed) and when spins are identically zero for all samples
|
|
* [ ] inference reproduces the same results when spins are neglected (--spin-column is not passed) and when spins are identically zero for all samples
|
|
|
* [ ] inference produces strictly larger estimates for P(m2<Mmax) when spins are included compared to when spins are neglected
|
|
* [ ] inference produces strictly larger estimates for P(m2<Mmax) when spins are included compared to when spins are neglected
|
|
|
* [ ] scaling of Mmax(Mtov, Rtov, spin) was correctly implemented based on Eqn 18 of (Breu+Rezzolla 2016)[https://academic.oup.com/mnras/article/459/1/646/2608837].
|
|
* [ ] scaling of Mmax(Mtov, Rtov, spin) was correctly implemented based on Eqn 18 of [Breu+Rezzolla 2016](https://academic.oup.com/mnras/article/459/1/646/2608837).
|
|
|
* [ ] unit conversion is done correctly within compactness calculation.
|
|
* [ ] unit conversion is done correctly within compactness calculation.
|
|
|
* [ ] (the updated) code can be run with minimal changes by cloning the repo
|
|
* [ ] the (updated) code can be run with minimal changes by cloning the repo
|
|
|
|
|
|
|
|
## Quantitative Results
|
|
## Quantitative Results
|
|
|
using `master` at [1f035f47](https://git.ligo.org/reed.essick/mmax-model-selection/-/commit/1f035f47c04ddd4c7f69947b96ff0c759479b68d) I get:
|
|
using `master` at [1f035f47](https://git.ligo.org/reed.essick/mmax-model-selection/-/commit/1f035f47c04ddd4c7f69947b96ff0c759479b68d) I get:
|
| ... | | ... | |
