... | @@ -39,6 +39,7 @@ This review wiki covers the changes to the code based in order to incorporate po |
... | @@ -39,6 +39,7 @@ This review wiki covers the changes to the code based in order to incorporate po |
|
* [ ] inference produces strictly larger estimates for P(m2<Mmax) when spins are included compared to when spins are neglected
|
|
* [ ] inference produces strictly larger estimates for P(m2<Mmax) when spins are included compared to when spins are neglected
|
|
* [ ] scaling of Mmax(Mtov, Rtov, spin) was correctly implemented based on Eqn 18 of [Breu+Rezzolla 2016](https://academic.oup.com/mnras/article/459/1/646/2608837).
|
|
* [ ] scaling of Mmax(Mtov, Rtov, spin) was correctly implemented based on Eqn 18 of [Breu+Rezzolla 2016](https://academic.oup.com/mnras/article/459/1/646/2608837).
|
|
* [ ] unit conversion is done correctly within compactness calculation.
|
|
* [ ] unit conversion is done correctly within compactness calculation.
|
|
|
|
* [ ] estimate of maximum spin based on (Mtov, Rtov) is correctly implemented based on Eqn 17 of [Breu+Rezzolla 2016](https://academic.oup.com/mnras/article/459/1/646/2608837)
|
|
* [ ] the (updated) code can be run with minimal changes by cloning the repo
|
|
* [ ] the (updated) code can be run with minimal changes by cloning the repo
|
|
|
|
|
|
## Quantitative Results
|
|
## Quantitative Results
|
... | | ... | |