Skip to content

Changes

Page history
Update General Review (post GW190814) authored by Reed Essick's avatar Reed Essick
Show whitespace changes
Inline Side-by-side
General-Review-(post-GW190814).md
View page @ 998caa9a
......@@ -21,6 +21,8 @@ This review wiki covers the changes to the code based in order to incorporate po
* [ ] Formalism described in [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) is correct
* [ ] Monte-Carlo point-estimates and error estimates derived in [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) are correct
* *Note!* Reed has since found smally typos in the error estimates published in these works (associated with covariance between "f" and "g", etc).
* **ACTION ITEM** (for Reed): update derivations to show correct error estimation and to include formulas for Bayes factor.
* [ ] Monte-Carlo algorithms are correctly implemented within calls to [utils.prob_odds](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/mmax_model_selection/utils.py#L335)
* [ ] population priors are correctly implemented within calls to [utils.population_weights](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/mmax_model_selection/utils.py#L107)
* [ ] reweighting of single-event posterior samples is by population priors is correctly done within the [mmax-model-selection executable](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/bin/mmax-model-selection#L138)
......