Update General Review (post GW190814) authored by Amanda Farah's avatar Amanda Farah
...@@ -88,7 +88,7 @@ marginalizing to compute posteriors and odds ratio ...@@ -88,7 +88,7 @@ marginalizing to compute posteriors and odds ratio
* [X] the (updated) code can be run with minimal changes by cloning the repo * [X] the (updated) code can be run with minimal changes by cloning the repo
- Review statement: this is true and is documented below for the [NSBH repo](https://git.ligo.org/reed.essick/o3-nsbh-mmax-model-selection). - Review statement: this is true and is documented below for the [NSBH repo](https://git.ligo.org/reed.essick/o3-nsbh-mmax-model-selection).
- Note that the person running needs to convert all .json and .dat files to csv files by following the steps outlined in the README. - Note that the person running needs to convert all .json and .dat files to csv files by following the steps outlined in the README.
- Commands run by reviewer and output are: - Commands run by reviewer and output are below, and the results are consistent with those contained in the [NSBH repo](https://git.ligo.org/reed.essick/o3-nsbh-mmax-model-selection) up to 10%
``` ```
[amanda.farah@ldas-grid mmax_review]$ git clone https://git.ligo.org/reed.essick/mmax-[amanda.farah@ldas-grid mmax_review]$ model-selection [amanda.farah@ldas-grid mmax_review]$ git clone https://git.ligo.org/reed.essick/mmax-[amanda.farah@ldas-grid mmax_review]$ model-selection
[amanda.farah@ldas-grid mmax_review]$ git fetch [amanda.farah@ldas-grid mmax_review]$ git fetch
...@@ -97,6 +97,7 @@ marginalizing to compute posteriors and odds ratio ...@@ -97,6 +97,7 @@ marginalizing to compute posteriors and odds ratio
[amanda.farah@ldas-grid mmax_review]$ conda activate mmax_review [amanda.farah@ldas-grid mmax_review]$ conda activate mmax_review
(mmax_review) [amanda.farah@ldas-grid mmax_review]$ conda install numpy (mmax_review) [amanda.farah@ldas-grid mmax_review]$ conda install numpy
(mmax_review) [amanda.farah@ldas-grid mmax_review]$ python setup.py install (mmax_review) [amanda.farah@ldas-grid mmax_review]$ python setup.py install
(mmax_review) [amanda.farah@ldas-grid mmax_review]$ cd ../
(mmax_review) [amanda.farah@ldas-grid mmax_review]$ git clone https://git.ligo.org/reed.essick/o3-nsbh-mmax-model-selection.git (mmax_review) [amanda.farah@ldas-grid mmax_review]$ git clone https://git.ligo.org/reed.essick/o3-nsbh-mmax-model-selection.git
(mmax_review) [amanda.farah@ldas-grid mmax_review]$ cd o3-nsbh-mmax-model-selection/ (mmax_review) [amanda.farah@ldas-grid mmax_review]$ cd o3-nsbh-mmax-model-selection/
(mmax_review) [amanda.farah@ldas-grid o3-nsbh-mmax-model-selection]$ for DAT in etc/*dat (mmax_review) [amanda.farah@ldas-grid o3-nsbh-mmax-model-selection]$ for DAT in etc/*dat
...@@ -134,7 +135,6 @@ GW200115-C01_PHMcombined_highspin_pesummary LEC-mtov-rtov ...@@ -134,7 +135,6 @@ GW200115-C01_PHMcombined_highspin_pesummary LEC-mtov-rtov
GW200115-C01_PHMcombined_highspin_pesummary FC-mmax GW200115-C01_PHMcombined_highspin_pesummary FC-mmax
``` ```
--- ---
# Motivation # Motivation
... ...
......