Changes

Page history
Update General Review (post GW190814) authored by Amanda Farah's avatar Amanda Farah
Show whitespace changes
Inline Side-by-side
General-Review-(post-GW190814).md
View page @ cc3fb9cc
...@@ -28,8 +28,8 @@ This review wiki covers the changes to the code based in order to incorporate po ...@@ -28,8 +28,8 @@ This review wiki covers the changes to the code based in order to incorporate po
* [X] Monte-Carlo algorithms are correctly implemented within calls to [utils.prob_odds](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/mmax_model_selection/utils.py#L434) (or [utils.post_prior_bayes](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/mmax_model_selection/utils.py#L476) as appropriate). * [X] Monte-Carlo algorithms are correctly implemented within calls to [utils.prob_odds](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/mmax_model_selection/utils.py#L434) (or [utils.post_prior_bayes](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/mmax_model_selection/utils.py#L476) as appropriate).
* [X] population priors are correctly implemented within calls to [utils.population_weights](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/mmax_model_selection/utils.py#L107) * [X] population priors are correctly implemented within calls to [utils.population_weights](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/mmax_model_selection/utils.py#L107)
* [X] reweighting of single-event posterior samples is by population priors is correctly done within the [mmax-model-selection executable](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/bin/mmax-model-selection#L153) * [X] reweighting of single-event posterior samples is by population priors is correctly done within the [mmax-model-selection executable](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/bin/mmax-model-selection#L153)
* [X] code can be run with minimal adjustments by cloning the repo
* [ ] code can be run on CIT with minimal adjustments by cloning the repo and results in [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) are reproducible. * [ ] results in [LIGO-P2000216](https://dcc.ligo.org/LIGO-P2000216) / [arXiv:2007.01372](https://arxiv.org/abs/2007.01372) are reproducible
--- ---
... ...
......