| ... | ... | @@ -32,6 +32,13 @@ This review wiki covers the changes to the code based in order to incorporate po |
|
|
|
* [X] reweighting of single-event posterior samples is by population priors is correctly done within the [mmax-model-selection executable](https://git.ligo.org/reed.essick/mmax-model-selection/-/blob/master/bin/mmax-model-selection#L153)
|
|
|
|
* [X] code can be run with minimal adjustments by cloning the repo
|
|
|
|
- Review statement: The `README` is slightly outdated in the repo, but error messages are informative and getting a working command is straightforward - see "Quantitative Results" section below for working commands run and corresponding output.
|
|
|
|
|
|
|
|
### Additional checklist items for addition of spin inference
|
|
|
|
|
|
|
|
* [ ] inference reproduces the same results when spins are neglected (--spin-column is not passed) and when spins are identically zero for all samples
|
|
|
|
* [ ] inference produces strictly larger estimates for P(m2<Mmax) when spins are included compared to when spins are neglected
|
|
|
|
* [ ] scaling of Mmax(Mtov, Rtov, spin) was correctly implemented based on Eqn 18 of (Breu+Rezzolla 2016)[https://academic.oup.com/mnras/article/459/1/646/2608837].
|
|
|
|
|
|
|
|
## Quantitative Results
|
|
|
|
using `master` at [1f035f47](https://git.ligo.org/reed.essick/mmax-model-selection/-/commit/1f035f47c04ddd4c7f69947b96ff0c759479b68d) I get:
|
|
|
|
```
|
| ... | ... | |
