... | ... | @@ -38,7 +38,9 @@ This review wiki covers the changes to the code based in order to incorporate po |
|
|
* [ ] inference reproduces the same results when spins are neglected (--spin-column is not passed) and when spins are identically zero for all samples
|
|
|
* [ ] inference produces strictly larger estimates for P(m2<Mmax) when spins are included (but known to be less than the break-up spin) compared to when spins are neglected
|
|
|
* [ ] scaling of Mmax(Mtov, Rtov, spin) was correctly implemented based on Eqn 18 of [Breu+Rezzolla 2016](https://academic.oup.com/mnras/article/459/1/646/2608837).
|
|
|
* [ ] unit conversion is done correctly within compactness calculation.
|
|
|
- Review statement: I have cross checked functions `br2016_max_spin()` and `br2016_mmax_scaling()` in `bin/mmax_model_selection/utils.py` with equations 17 and 18 in the above paper. The former appears correct, but the latter seems to have an error. Namely, the second term in the mmax expression should have a factor of the compactness squared, but it is currently to the 1st power.
|
|
|
* [X] unit conversion is done correctly within compactness calculation.
|
|
|
- Review statement: unit conversion was checked by hand and via the `astropy` `units` module.
|
|
|
* [ ] estimate of maximum spin based on (Mtov, Rtov) is correctly implemented based on Eqn 17 of [Breu+Rezzolla 2016](https://academic.oup.com/mnras/article/459/1/646/2608837)
|
|
|
* [ ] the (updated) code can be run with minimal changes by cloning the repo
|
|
|
|
... | ... | |