Zero issueshttps://git.ligo.org/sean-leavey/zero/-/issues2020-01-29T22:36:19Zhttps://git.ligo.org/sean-leavey/zero/-/issues/51Give warning when using wrong node name in AcSignalAnalysis.calculate()2020-01-29T22:36:19ZAnchal GuptaGive warning when using wrong node name in AcSignalAnalysis.calculate()I discovered that AcSignalAnalysis.calculate() does not give any warning or error if the wrong node name is given as an argument to it. AcNoiseAnalysis, on the other hand, gives an error for the same mistake by the user. We should correc...I discovered that AcSignalAnalysis.calculate() does not give any warning or error if the wrong node name is given as an argument to it. AcNoiseAnalysis, on the other hand, gives an error for the same mistake by the user. We should correct this. Attaching a simple code that tests this case.[zeroNodeWrongNameTest.py](/uploads/71dd61dd38cce35b1fd3e1a22ed4ff38/zeroNodeWrongNameTest.py)Sean LeaveySean Leaveyhttps://git.ligo.org/sean-leavey/zero/-/issues/32Respect LISO's plot ordering when plotting a LISO input or output file.2019-05-07T15:03:13ZSean LeaveyRespect LISO's plot ordering when plotting a LISO input or output file.Since solution merging was introduced in 623a9034, colour wheels on plots are no longer reset when plotting LISO equivalents, so colours for equivalent functions are different. Since now the plotting tool doesn't know the difference betw...Since solution merging was introduced in 623a9034, colour wheels on plots are no longer reset when plotting LISO equivalents, so colours for equivalent functions are different. Since now the plotting tool doesn't know the difference between functions merged from different solutions, add a new plot spec to functions store a "colour wheel group".
UPDATE 2019/05/07: colours now match when comparing LISO to Zero, but absolute order when running a Zero on its own with a LISO input file still differs from what LISO produces.Sean LeaveySean Leaveyhttps://git.ligo.org/sean-leavey/zero/-/issues/29Handle mutual inductances where one component has been deleted2019-08-08T06:14:46ZSean LeaveyHandle mutual inductances where one component has been deletedMutual inductances are stored in `Inductor` objects, but they have no way of knowing if the other inductor has since been deleted from the circuit. Perhaps use `weakref` to check, or have the `Circuit` object deal with cleaning up induc...Mutual inductances are stored in `Inductor` objects, but they have no way of knowing if the other inductor has since been deleted from the circuit. Perhaps use `weakref` to check, or have the `Circuit` object deal with cleaning up inductor references.Node graphsSean LeaveySean Leaveyhttps://git.ligo.org/sean-leavey/zero/-/issues/17Detect unconnected nodes in input file and warn user2019-07-03T08:32:34ZSean LeaveyDetect unconnected nodes in input file and warn userNodes that aren't connected to anything can result in outputs that may confuse the user. The simulation currently runs anyway but gets a singular matrix with no results. For example, this circuit without a grounded negative input:
```py...Nodes that aren't connected to anything can result in outputs that may confuse the user. The simulation currently runs anyway but gets a singular matrix with no results. For example, this circuit without a grounded negative input:
```python
from circuit.liso import LisoInputParser
p = LisoInputParser()
p.parse("r r1 1k n1 ninp")
p.parse("op op1 op27 ninp ninm nout")
p.parse("r r2 100k nout ninp")
p.parse("uinput n1")
p.parse("uoutput nout")
p.parse("freq log 1 100k 1000")
p.show()
```
This prints...
```
usr/local/lib/python3.5/dist-packages/scipy/sparse/linalg/dsolve/linsolve.py:192: MatrixRankWarning: Matrix is exactly singular
warn("Matrix is exactly singular", MatrixRankWarning)
```
...but still attempts to plot the (empty) results.
The solver should check that the nodes are all connected to something.Sean LeaveySean Leavey