Code-Review.md

@@ -383,7 +383,6 @@ Meeting ID: 860 7262 9011 Password: 001303
 * [x] retrain densenets using whitened QTs, wider qrange etc.
 
 * [x] Ask lensing group for the O3b representative psd.
-* [ ] Gather injection parameters for O3b background from Apratim.
 * [x] It seems that the dimensions of Healpix grid for bayestar skymaps is same. Compare the overlap and other statistic with the current cartesian map method to the bayestar-skymap-flatten skymap method.
 * [ ] Test robustness of ML with spinning binaries.
 
@@ -443,8 +442,6 @@ Meeting ID: 860 7262 9011 Password: 001303
 * the next meeting call shall be on January 4, 3 PM CEST most likely.
 
 ### Action items:
-* [ ] Ask Justin for Golum lensed injections study if any.
-* [ ] Produce results with whitening for the O3.
 * [x] Investigate the ML with QTs for the 4 outliers.
 * [x] Make a result review page. [O3b lensing result review](https://git.ligo.org/srashti.goyal/lensid/-/wikis/Result-Review-O3b-lensing)
 
@@ -455,6 +452,23 @@ Meeting ID: 860 7262 9011 Password: 001303
 *  We converged on the training configurations for the final ML results for O3.
 
 ### Action items:
-* [ ] Retrain XGBoost by putting NaN's randomly and without filling 1 in place of NaNs.
-* [ ] Produce the final results asap.
+* [x] Retrain XGBoost by putting NaN's randomly and without filling 1 in place of NaNs.
+ 
+## 12 January 2021
+* We discussed about training XGBoost with missing values. i.e. for single or double detector events. Imputing before training is the only option seems feasible.
+
+* Imputing using mean/median strategy is implemented [here](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/tree/master/review). Another possibility is to do regression like [this](https://medium.com/swlh/impute-missing-values-the-right-way-c63735fccccd) post.
+
+* We also discussed the performance of the current pipeline with simulated super subthreshold lensed and unlensed event pairs. The performance is not bad. [notebook](https://git.ligo.org/srashti.goyal/lensid/-/blob/master/subthreshold/test_super_sub_pairs.ipynb)
+
+* Lastly we saw that [pair S190412m & S200129m](https://docs.google.com/presentation/d/1k-xPvD8iAknxt-JVfI-Fbr4SfS_Adnlh3Q8u1fR4KJc/edit#slide=id.p) which is thought to be type 2 image by Golum, doesn't seem to be lensed as is eliminated by both PO and lensid pipeline and also has almost zero mass and sky overlaps, as seen [here](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/blob/967e30eb7166546b8a858cdf68ab0a5275730119/review/investigations_visualisations.ipynb) 
 
+* We will meet next Wednesday 3 pm CEST.
+
+### Action items:
+
+* [ ] Solve single/double detector issue.
+* [ ] Gather injection parameters for O3b background from Apratim.
+* [ ] Produce results with whitening for the O3.
+* [ ] Produce the final O3 results asap.
+* [ ] Produce preliminary results for super-sub pairs [found](https://sites.google.com/ligo.org/gstlal-sensedb/search?) by Alvin here.