Changes

Page history
Update Code Review authored by Srashti Goyal's avatar Srashti Goyal
Hide whitespace changes
Inline Side-by-side
Code-Review.md
View page @ 06d98736
...@@ -405,7 +405,7 @@ Meeting ID: 860 7262 9011 Password: 001303 ...@@ -405,7 +405,7 @@ Meeting ID: 860 7262 9011 Password: 001303
* [ ] increase training set size, check convergence. * [ ] increase training set size, check convergence.
* [x] Ask lensing group for the O3b representative psd. * [x] Ask lensing group for the O3b representative psd.
* [ ] Gather injection parameters for O3b background from Apratim. * [ ] Gather injection parameters for O3b background from Apratim.
* [ ] It seems that the dimensions of Healpix grid for bayestar skymaps is same. Compare the overlap and other statistic with the current cartesian map method to the bayestar-skymap-flatten skymap method. * [x] It seems that the dimensions of Healpix grid for bayestar skymaps is same. Compare the overlap and other statistic with the current cartesian map method to the bayestar-skymap-flatten skymap method.
* [ ] Test robustness of ML with spinning binaries. * [ ] Test robustness of ML with spinning binaries.
## 9 November 2021 ## 9 November 2021
...@@ -429,6 +429,6 @@ Meeting ID: 860 7262 9011 Password: 001303 ...@@ -429,6 +429,6 @@ Meeting ID: 860 7262 9011 Password: 001303
### Action items: ### Action items:
* [ ] Look into skymap calculations, theta to declination conversion as JR pointed out. * [x] Look into skymap calculations, theta to declination conversion as JR pointed out.
* [ ] Produce a better version of results as soon as possible. * [ ] Produce a better version of results as soon as possible.
* [x] Wrap up the code review. * [x] Wrap up the code review.