Code-Review.md

@@ -64,21 +64,17 @@ The ML model predictions are compared to posterior overlap statistic results als
 * Simulated data preparation: QTs, skymaps, Dataframes, injection parameters, BLU etc.
 * Feature Extraction: Qtransforms and sky-features.
 * Machine learning utilities.
+* ML models: Training, Cross-validation, Optimisation, Testing, comparison with BLU, FPP computation.
+* ML predictions
 
-#### ML models: Training, Cross-validation, Optimisation, Testing
-
-* ML with QTs (densenets, XGBoost)
-* ML with skymaps (XGBoost)
-* ML testing, comparison with BLU, FPP computation.
-
-#### ML predictions: Real events analysis.
+#### O3: Real events analysis of lensid. Git repo: [lensid-ml-o3](https://git.ligo.org/srashti.goyal/lensid-ml-o3)
 
 * Simulated events for background computation. For getting FAPs.
 * Real events data download and preparation.
 * Machine learning with O3a and O3b events. Comparison to BLU.
 * subthreshold events?
 
-#### Top level scripts: train-test workflow, data generation workflow, ML predictions workflow.
+#### Top level scripts: train-test workflow, data generation workflow.
 
 ## Package Scripts
 
@@ -104,7 +100,7 @@ The ML model predictions are compared to posterior overlap statistic results als
 | [lensid_get_features_sky_ml.py](https://git.ligo.org/srashti.goyal/lensid/-/blob/master/package/lensid/feature_extraction/lensid_get_features_sky_ml.py) | Script for calculating features from the bayestar skymaps which go as input to "XGBoost with Skymaps" model. Eg: `lensid_get_features_sky_ml -infile check/lensed.csv -outfile check/lensed_sky.csv -data_dir check` | -OK- , OK-jrc | -------- | ------- | -------------- |
 | [ml_utils.py](https://git.ligo.org/srashti.goyal/lensid/-/blob/master/package/lensid/utils/ml_utils.py) | utility script containing all machine learning model functions for training, FAP computation, predictions etc. | in progress-jrc | -------- | Why is leakyrelu loaded? The logic of rfn(epoch) could be simplified.------- | -------------- |
 
-### ML models: Predictions, Training, Cross-validation, Optimisation, Testing, Comparison with BLU 
+### ML models:  Training, Cross-validation, Optimisation, Testing, Comparison with BLU , Predictions
 
 | Scripts | Short description | Status | git hash | Comment | final sign-off |
 |---------|-------------------|--------|----------|---------|----------------|
@@ -124,7 +120,6 @@ The ML model predictions are compared to posterior overlap statistic results als
 
 ## ML Predictions: O3 Real events, Data preparation, FAP computation, Comparison with BLU
 
-### O3 analysis in git repo: [lensid-ml-o3](https://git.ligo.org/srashti.goyal/lensid-ml-o3)
 | Notebook/Scripts | Short description | Status | git hash | Comment | final sign-off |
 |------------------|-------------------|--------|----------|---------|----------------|
 | [download_data.ipynb](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/blob/master/data_download_preparation/download_data.ipynb) | Notebook for downloading skymaps(.fits) from GraceDB and strain data from ligo servers using GWpy. | ------ | -------- | ------- | -------------- |