Skip to content

Changes

Page history
Update Code Review authored by Srashti Goyal's avatar Srashti Goyal
Show whitespace changes
Inline Side-by-side
Code-Review.md
View page @ 2a750fbe
...@@ -439,7 +439,7 @@ Meeting ID: 860 7262 9011 Password: 001303 ...@@ -439,7 +439,7 @@ Meeting ID: 860 7262 9011 Password: 001303
### Action items: ### Action items:
* [ ] Fix learning rates for densenets as JR suggested. * [ ] Fix learning rates for densenets as JR suggested.
* [ ] Compare ML FPP and BLU FPP with [GOLUM's CLU](https://docs.google.com/spreadsheets/d/1wrpzwudP1MbraJNlCB6arnTCzbeuCPLBx16eReMdQvM/edit#gid=899668020) * [x] Compare ML FPP and BLU FPP with [GOLUM's CLU]. (https://docs.google.com/spreadsheets/d/1wrpzwudP1MbraJNlCB6arnTCzbeuCPLBx16eReMdQvM/edit#gid=899668020). [notebook](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/blob/master/review/comparison_with_golum.ipynb)
* [x] Share updated results with Justin, after optimisation perhaps. * [x] Share updated results with Justin, after optimisation perhaps.
* [x] Figure out why the unlensed pairs FPP in O3a background and in test set is not going below 1e-3, whereas test lensed pairs is going upto 1e-5. * [x] Figure out why the unlensed pairs FPP in O3a background and in test set is not going below 1e-3, whereas test lensed pairs is going upto 1e-5.
* [x] Produce whitened QTs results. * [x] Produce whitened QTs results.
...@@ -452,4 +452,16 @@ Meeting ID: 860 7262 9011 Password: 001303 ...@@ -452,4 +452,16 @@ Meeting ID: 860 7262 9011 Password: 001303
* Discussed about a few events which have BLU FPP 1 but ML FPP<1e-2. * Discussed about a few events which have BLU FPP 1 but ML FPP<1e-2.
### Action items: ### Action items:
* [ ] Write a script or notebook for investigating a particular pair. * [x] Write a script or notebook for investigating a particular pair. [notebook](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/blob/master/review/investigations_visualisations.ipynb)
\ No newline at end of file
## 21 December 2021
* We discussed the ML and BLU results comparison to GOLUM. [notebook](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/blob/master/review/comparison_with_golum.ipynb)
* We investigated the 4 outliers for the ML FPP v/s GOlum CLU and found them to be all associated with a same single detector event, using this [notebook](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/blob/master/review/investigations_visualisations.ipynb).
* JR suggested to test machine learning with whitening, and investigate the issue with single det events like this further.
* the next meeting call shall be on January 4, 3 PM CEST most likely.
## Action items:
* [ ] Ask Justin for Golum lensed injections study if any.
* [ ] Produce results with whitening for the O3.
* [ ] Investigate the ML with QTs for the 4 outliers.
* [ ] Make a result review page.