Changes

Page history
Update Code Review authored by Srashti Goyal's avatar Srashti Goyal
Show whitespace changes
Inline Side-by-side
Code-Review.md
View page @ 2ff58645
...@@ -400,8 +400,8 @@ Meeting ID: 860 7262 9011 Password: 001303 ...@@ -400,8 +400,8 @@ Meeting ID: 860 7262 9011 Password: 001303
* [x] simplify/optimise the learning rate scheduler in densenets training. * [x] simplify/optimise the learning rate scheduler in densenets training.
* [ ] cosmetic changes in column names for BLU dataframes. * [ ] cosmetic changes in column names for BLU dataframes.
* [ ] write script for systematic BLU calculation and plots for the O3 real events. * [ ] write script for systematic BLU calculation and plots for the O3 real events.
* [x] retrain densenets using whitened QTs, wider qrange etc, * [x] retrain densenets using whitened QTs, wider qrange etc.
* [ ] optimise XGB with QTs with, more info, missing data etc. * [ ] optimise XGB with QTs with, more info, missing data etc. [script](https://git.ligo.org/srashti.goyal/lensid/-/blob/master/development/optimise_densenets.py) [notebook](https://git.ligo.org/srashti.goyal/lensid/-/blob/master/development/optimise_XGB_QTs.ipynb)
* [ ] increase training set size, check convergence. * [ ] increase training set size, check convergence.
* [x] Ask lensing group for the O3b representative psd. * [x] Ask lensing group for the O3b representative psd.
* [ ] Gather injection parameters for O3b background from Apratim. * [ ] Gather injection parameters for O3b background from Apratim.
...@@ -435,9 +435,16 @@ Meeting ID: 860 7262 9011 Password: 001303 ...@@ -435,9 +435,16 @@ Meeting ID: 860 7262 9011 Password: 001303
## 3 December 2021 ## 3 December 2021
* Discuss the plot going to the paper. * Discuss the plot going to the paper. [notebook](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/blob/master/O3_ML_gwtc3/plot_ml_blu_predictions.ipynb)
* Skymap sanity check. * Skymap sanity check.[notebook](https://git.ligo.org/srashti.goyal/lensid/-/blob/master/review/hp_cartview.ipynb)
* XGBQT optimisation, include phenom and include power exploration etc. * XGBQT optimisation, include phenom and include power exploration etc.
* Updated results * Updated [results](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/tree/master/O3_ML_gwtc3/results_3dec_kaggle) with more events considered by Posterior overlap analysis. [notebook](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/blob/master/O3_ML_gwtc3/get_candidates_compare_to_blu_tagged.ipynb)
### Action items: ### Action items:
* [ ] Fix learning rates for densenets as JR suggested.
* [ ] Compare ML FPP and BLU FPP with [GOLUM's CLU](https://docs.google.com/spreadsheets/d/1wrpzwudP1MbraJNlCB6arnTCzbeuCPLBx16eReMdQvM/edit#gid=899668020)
* [ ] Share updated results with Justin, after optimisation perhaps.
* [ ] Figure out why the unlensed pairs FPP in O3a background and in test set is not going below 1e-3, whereas test lensed pairs is going upto 1e-5.
* [ ] Produce whitened QTs results.