Skip to content

Changes

Page history
Update Code Review authored by Srashti Goyal's avatar Srashti Goyal
Show whitespace changes
Inline Side-by-side
Code-Review.md
View page @ a069185f
...@@ -398,11 +398,9 @@ Meeting ID: 860 7262 9011 Password: 001303 ...@@ -398,11 +398,9 @@ Meeting ID: 860 7262 9011 Password: 001303
### Action items: ### Action items:
* [x] simplify/optimise the learning rate scheduler in densenets training. * [x] simplify/optimise the learning rate scheduler in densenets training.
* [ ] cosmetic changes in column names for BLU dataframes.
* [ ] write script for systematic BLU calculation and plots for the O3 real events. * [ ] write script for systematic BLU calculation and plots for the O3 real events.
* [x] retrain densenets using whitened QTs, wider qrange etc. * [x] retrain densenets using whitened QTs, wider qrange etc.
* [ ] optimise XGB with QTs with, more info, missing data etc. [script](https://git.ligo.org/srashti.goyal/lensid/-/blob/master/development/optimise_densenets.py) [notebook](https://git.ligo.org/srashti.goyal/lensid/-/blob/master/development/optimise_XGB_QTs.ipynb) * [ ] optimise XGB with QTs with, more info, missing data etc. [script](https://git.ligo.org/srashti.goyal/lensid/-/blob/master/development/optimise_densenets.py) [notebook](https://git.ligo.org/srashti.goyal/lensid/-/blob/master/development/optimise_XGB_QTs.ipynb)
* [ ] increase training set size, check convergence.
* [x] Ask lensing group for the O3b representative psd. * [x] Ask lensing group for the O3b representative psd.
* [ ] Gather injection parameters for O3b background from Apratim. * [ ] Gather injection parameters for O3b background from Apratim.
* [x] It seems that the dimensions of Healpix grid for bayestar skymaps is same. Compare the overlap and other statistic with the current cartesian map method to the bayestar-skymap-flatten skymap method. * [x] It seems that the dimensions of Healpix grid for bayestar skymaps is same. Compare the overlap and other statistic with the current cartesian map method to the bayestar-skymap-flatten skymap method.
......