Code-Review.md

@@ -446,7 +446,7 @@ Meeting ID: 860 7262 9011 Password: 001303
 * [x] Make a result review page. [O3b lensing result review](https://git.ligo.org/srashti.goyal/lensid/-/wikis/Result-Review-O3b-lensing)
 
 
-## 5 January 2021
+## 5 January 2022
 * We discussed the performance of XGBoost with QTs for the 2 detector real events.
 * Imputing the dense outputs(i.e. input features of XGBoost) for the missing data help but is not logically understood. (notebook)[https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/blob/master/review/missing_strain_ML_qts.ipynb] 
 *  We converged on the training configurations for the final ML results for O3.
@@ -454,7 +454,7 @@ Meeting ID: 860 7262 9011 Password: 001303
 ### Action items:
 * [x] Retrain XGBoost by putting NaN's randomly and without filling 1 in place of NaNs.
  
-## 12 January 2021
+## 12 January 2022
 * We discussed about training XGBoost with missing values. i.e. for single or double detector events. Imputing before training is the only option seems feasible.
 
 * Imputing using mean/median strategy is implemented [here](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/tree/master/review). Another possibility is to do regression like [this](https://medium.com/swlh/impute-missing-values-the-right-way-c63735fccccd) post.
@@ -472,7 +472,7 @@ Meeting ID: 860 7262 9011 Password: 001303
 * [x] Produce the final O3 results asap.
 * [x] Produce preliminary results for super-sub pairs [found](https://sites.google.com/ligo.org/gstlal-sensedb/search?) by Alvin here.
 
-## 25 January 2021
+## 25 January 2022
 
 * We discussed the preliminary results for the O3 super subthreshold pairs.[notebook](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/blob/master/subthreshold/get_candidates_super_sub.ipynb)
 
@@ -482,12 +482,31 @@ Meeting ID: 860 7262 9011 Password: 001303
 
 * We  [merged](https://git.ligo.org/srashti.goyal/lensid/-/merge_requests/2) the changes to the pipeline incorporated to include different data directories for super and sub threshold events , and  the minor changes for  single double det events in the ML with QTs.
 
-### Action items.:
+### Action items:
 
 * [ ] Gather injection parameters for O3b background from Apratim.
 
-* [ ] Update code review and result review page.
+* [x] Update code review and result review page.
+
+* [x] Update the plot that is supposed to go into the paper.
+
+* [x] Keep investigating and improving. Make a note of the possible improvements for O4 and O5.
+
+## 10th and 16th February 2022
+
+*  We discussed about the two different strategies for imputation: sklearn's median and verstack's regression. Seems that sklearn is a little better choice. [notebook](https://git.ligo.org/srashti.goyal/lensid-ml-o3/-/blob/master/review/investigate_missing_strain_ML_qts.ipynb).
+
+* We also discussed about skymaps getting affected due two no. of detectors and hence their chance of overlap. This issue could be addressed perhaps by simulating single/double detector events background, for O4 development.
+
+* We also discussed that in ML with QTs the relation between the waveform from different detectors is not taken into account, also the skymaps and QTs are put on equal footing while calculating the FPPs. This is again something to think about for O4.
+
+* We discussed about the pair (S191103a-S191105e) that had highest CLU with hanabi so far, and is selected by PO analysis but is missed by the ML lensid pipeline.[slides](https://docs.google.com/presentation/d/1d_f5mUeT5PonFH3dd0c0VxlPxo9Hwd4uYOJRkhocRpQ/edit#slide=id.p). There are two possible reasons, one is that bayestar skymaps **used** is incorrect or not good and the ML is not doing good with QTs for low mass binaries. 
+
+* The ML is not trained with good no. of low mass binaries, which JR suggested should be in development for O4.
+
+### Action items:
+
+* [ ] Check the bayestar skymaps for all events, specially for S191103a-S191105e, and re-do the analysis based on correct channels and bayestar skymaps.
 
-* [ ] Update the plot that is supposed to go into the paper.
+* [ ]  Make note of all possible improvements for O4 .
 
-* [ ] Keep investigating and improving. Make a note of the possible improvements for O4 and O5.
\ No newline at end of file