- We discussed about packaging of the pipeline, and the git issue which Deep created. (here)[https://git.ligo.org/srashti.goyal/strong-lensing-ml/-/issues/1].
- We discussed about packaging of the pipeline, and the git issue which Deep created. [here](https://git.ligo.org/srashti.goyal/strong-lensing-ml/-/issues/1).
- We also discussed about the preliminary results and deciding on threshold on FPP for getting the candidate pairs.
...
...
@@ -294,7 +294,7 @@ Password: 001303
- [x] Investigate extreme events in the test set for the BLU & ML, by seeing their QTs and skymaps to understand the independent behaviour of ML & BLU.
- [x] Use entry points as mentioned (here)[https://git.ligo.org/srashti.goyal/strong-lensing-ml/-/issues/1].
-[x] Use entry points as mentioned [here](https://git.ligo.org/srashti.goyal/strong-lensing-ml/-/issues/1).
- [x] Create new repo for the package and package data, and probably move this review page also over there.
...
...
@@ -303,11 +303,11 @@ Password: 001303
- Deep suggested to include unit test with the code.
- JR and Srashti discussed the events list for O3b lensing paper, seeing the (document)[https://docs.google.com/spreadsheets/d/1rV-b2HE2mGxrxRl9-rdEunLsp9f5S5sMhD5EauI1-nE/edit?usp=sharing] prepared by Justin.
- JR and Srashti discussed the events list for O3b lensing paper, seeing the [document](https://docs.google.com/spreadsheets/d/1rV-b2HE2mGxrxRl9-rdEunLsp9f5S5sMhD5EauI1-nE/edit?usp=sharing) prepared by Justin.
- The whitening procedure is fixed for injections, the low frequency cut(flow) in psd generation was the problem. Notebook (here)[https://git.ligo.org/srashti.goyal/lensid/-/blob/master/review/whitening_investigations.ipynb].
- The whitening procedure is fixed for injections, the low frequency cut(flow) in psd generation was the problem. Notebook [here](https://git.ligo.org/srashti.goyal/lensid/-/blob/master/review/whitening_investigations.ipynb).
- We discussed the events which have low ML FPP but high BLU FPP and vice versa, for the test set, by seeing the qtransforms and bayestar + PE skymaps for them. Notebook (here)[https://git.ligo.org/srashti.goyal/lensid/-/blob/master/review/ML_blu_FPPs_inj_pars_investigate.ipynb]
- We discussed the events which have low ML FPP but high BLU FPP and vice versa, for the test set, by seeing the qtransforms and bayestar + PE skymaps for them. Notebook [here](https://git.ligo.org/srashti.goyal/lensid/-/blob/master/review/ML_blu_FPPs_inj_pars_investigate.ipynb)
- J.R. thinks that the pipeline is almost ready for the code review and sign-off can happen within a week or two.
