Update Result Review O4a authored by Jean-Rene Cudell's avatar Jean-Rene Cudell
...@@ -12,7 +12,6 @@ O4a repo: [lensid-ml-o4](https://git.ligo.org/srashti.goyal/lensid-ml-o4) ...@@ -12,7 +12,6 @@ O4a repo: [lensid-ml-o4](https://git.ligo.org/srashti.goyal/lensid-ml-o4)
`/home/srashti.goyal/lensid_O4/data_download_preparation` and `/home/srashti.goyal/lensing_MDC_O4/data_prep/data` `/home/srashti.goyal/lensid_O4/data_download_preparation` and `/home/srashti.goyal/lensing_MDC_O4/data_prep/data`
## Useful links ## Useful links
- slides [Till O3 method, review, results](https://docs.google.com/presentation/d/10bIhtFae5RIJ3WBJg1Lcy7PueSKwxh1m2APRDN0w0PA/edit?usp=sharing) - slides [Till O3 method, review, results](https://docs.google.com/presentation/d/10bIhtFae5RIJ3WBJg1Lcy7PueSKwxh1m2APRDN0w0PA/edit?usp=sharing)
...@@ -27,30 +26,125 @@ O4a repo: [lensid-ml-o4](https://git.ligo.org/srashti.goyal/lensid-ml-o4) ...@@ -27,30 +26,125 @@ O4a repo: [lensid-ml-o4](https://git.ligo.org/srashti.goyal/lensid-ml-o4)
### Reviewer: Jean-Rene Cudell ### Reviewer: Jean-Rene Cudell
Final Sign-off: Final Sign-off: Date:
Date:
Git hash: Git hash:
# Result review # Result review
## Review materials ## Review materials
| Script | Short description | Status | git hash | Comment | final sign-off |
|--------|-------------------|--------|----------|---------|----------------|
| [data_download_cbcflow.py](https://git.ligo.org/srashti.goyal/lensid-ml-o4/-/blob/master/data_download_preparation/data_download_cbcflow.py) | Script for downloading events info from CBCFlow (path loaded on CIT), skymaps(.fits) from GraceDB and strain data from ligo servers using GWpy. Note: needs valid ligo key path for accessing non-public data in Gracedb., eg: `/tmp/x509up\\\\\\\*` Raw data on CIT is in `/home/srashti.goyal/lensid_O4/data_download_preparation/O4a_events_data`| | | ------- | |
| [data_prepare.py](https://git.ligo.org/srashti.goyal/lensid-ml-o4/-/blob/master/data_download_preparation/data_prepare.py) | Prepare cartesian skymaps and qtransforms for O4a the real events. Also filters events compatible with lensid (BBHs) and prepares a dataframe. Note: The prepared inputs are saved on CIT in `/home/srashti.goyal/lensid_O4/data_download_preparation/O4a_lensid_inputs` | | | --- | |
| [2vs3det.ipynb](https://git.ligo.org/srashti.goyal/lensid-ml-o4/-/blob/master/retraining_for_O4/2vs3det.ipynb) | Skymaps ML performance for HL v/s HLV | | | -------------- |
| [PSD_plots.ipynb](https://git.ligo.org/srashti.goyal/lensid-ml-o4/-/blob/master/retraining_for_O4/PSD_plots.ipynb) | Comparison of the PSDs used for training and testing in O3 and O4 etc. *will be changed* | | | -------------- |
<details><summary>**YET to FINALISE**</summary> <table>
<tr>
<th>Script</th>
<th>Short description</th>
<th>Status</th>
<th>git hash</th>
<th>Comment</th>
<th>final sign-off</th>
</tr>
<tr>
<td>
[data_download_cbcflow.py](https://git.ligo.org/srashti.goyal/lensid-ml-o4/-/blob/master/data_download_preparation/data_download_cbcflow.py)
</td>
<td>
Script for downloading events info from CBCFlow (path loaded on CIT), skymaps(.fits) from GraceDB and strain data from ligo servers using GWpy. Note: needs valid ligo key path for accessing non-public data in Gracedb., eg: `/tmp/x509up\\\\\\\*` Raw data on CIT is in `/home/srashti.goyal/lensid_O4/data_download_preparation/O4a_events_data`
</td>
<td>question on os</td>
<td>
</td>
<td>
include a link to the instructions for generating the LIGO key path in comments.
Not sure I understand `os.environ['OPENBLAS_NUM_THREADS'] = '4'`
</td>
<td>
</td>
</tr>
<tr>
<td>
[data_prepare.py](https://git.ligo.org/srashti.goyal/lensid-ml-o4/-/blob/master/data_download_preparation/data_prepare.py)
</td>
<td>
Prepare cartesian skymaps and qtransforms for O4a the real events. Also filters events compatible with lensid (BBHs) and prepares a dataframe. Note: The prepared inputs are saved on CIT in `/home/srashti.goyal/lensid_O4/data_download_preparation/O4a_lensid_inputs`
</td>
<td>
</td>
<td>
</td>
<td>
\---
</td>
<td></td>
</tr>
<tr>
<td>
[2vs3det.ipynb](https://git.ligo.org/srashti.goyal/lensid-ml-o4/-/blob/master/retraining_for_O4/2vs3det.ipynb)
</td>
<td>Skymaps ML performance for HL v/s HLV</td>
<td>
</td>
<td>
</td>
<td>
\--------------
</td>
<td>
</td>
</tr>
<tr>
<td>
[PSD_plots.ipynb](https://git.ligo.org/srashti.goyal/lensid-ml-o4/-/blob/master/retraining_for_O4/PSD_plots.ipynb)
</td>
<td>
Comparison of the PSDs used for training and testing in O3 and O4 etc. _will be changed_
</td>
<td>
</td>
<td>
</td>
<td>
\--------------
</td>
<td>
</td>
</tr>
</table>
<details>
<summary>
\*\*YET to FINALISE\*\*
</summary>
| Notebook | Short description | Status | Comment | Reviewed | | Notebook | Short description | Status | Comment | Reviewed |
|----------|-------------------|--------|---------|----------| |----------|-------------------|--------|---------|----------|
| [pop_datasets.ipynb](https://git.ligo.org/srashti.goyal/lensid-ml-o4/-/blob/master/retraining_for_O4/pop_datasets.ipynb) | Notebook having plots of injection parameters for training and testing. | | | -------------- | | [pop_datasets.ipynb](https://git.ligo.org/srashti.goyal/lensid-ml-o4/-/blob/master/retraining_for_O4/pop_datasets.ipynb) | Notebook having plots of injection parameters for training and testing. | | | \-------------- |
| Config | ML models and config for production runs | | | -------------- | | Config | ML models and config for production runs | | | \-------------- |
| PSDs | PSD used for training and testing | | | -------------- | | PSDs | PSD used for training and testing | | | \-------------- |
| ML_train_test_optimise_fpp | ML models benchmark performance and background estimations. | | | -------------- | | ML_train_test_optimise_fpp | ML models benchmark performance and background estimations. | | | \-------------- |
| Investigate pairs | Eyeballing pairs and compare the performances with the other pipelines | | | -------------- | | Investigate pairs | Eyeballing pairs and compare the performances with the other pipelines | | | \-------------- |
</details> </details>
...@@ -61,38 +155,33 @@ The review call happen on Wednesdays 1 PM CEST/ 4:30 PM IST virtual IFPA room: h ...@@ -61,38 +155,33 @@ The review call happen on Wednesdays 1 PM CEST/ 4:30 PM IST virtual IFPA room: h
## 13 July 2023 ## 13 July 2023
* We discussed the plan and action items for finalising the machine for production run. * We discussed the plan and action items for finalising the machine for production run.
- PSD for training and testing. - PSD for training and testing.
- Population: astro (haris et al 1400+1400) , astro (O4) v/s uniform (8000+8000) v/s ensembling - Population: astro (haris et al 1400+1400) , astro (O4) v/s uniform (8000+8000) v/s ensembling
- training set size, Overfitting and optimization, variance. - training set size, Overfitting and optimization, variance.
- Subthreshold: ROCs, single det > 4 - Subthreshold: ROCs, single det \> 4
- Detectors H L and H L V ? - Detectors H L and H L V ?
- Generate Background (later) - Generate Background (later)
- Noise: Gaussian v/s real (O4b) - Noise: Gaussian v/s real (O4b)
* We discussed the Data Preparation steps for O4a real events * We discussed the Data Preparation steps for O4a real events
- Event list (CBCFlow) - Event list (CBCFlow)
- Downloading to frame files, skymaps - Downloading to frame files, skymaps
- Config for running ML - Config for running ML
- Fixing the Passing criteria (top 1 %) - Fixing the Passing criteria (top 1 %)
### Action items: ### Action items:
- [x] O4 pop + uniform train and test and vary the training set size * [x] O4 pop + uniform train and test and vary the training set size
## 1 August 2023 ## 1 August 2023
* We discussed the three populations used for training and testing ML QTs: uniform, old astrophysical haris et al, O4 astrophysical pop. * We discussed the three populations used for training and testing ML QTs: uniform, old astrophysical haris et al, O4 astrophysical pop.
* The uniform pop-trained machine or a combination of O4 astro + uniform pop-trained machine, as they seem more robust towards population model assumptions. * The uniform pop-trained machine or a combination of O4 astro + uniform pop-trained machine, as they seem more robust towards population model assumptions.
* We also discussed the possibility of methods paper and having real noise MDC for the ongoing efforts. * We also discussed the possibility of methods paper and having real noise MDC for the ongoing efforts.
* We also discussed the data preparation for O4, using the CBCflow and which skymaps to use. * We also discussed the data preparation for O4, using the CBCflow and which skymaps to use.
## Action items ## Action items
- [x] Write data download and preparation scripts. * [x] Write data download and preparation scripts.
## 17 August 2023 ## 17 August 2023
...@@ -103,23 +192,21 @@ The review call happen on Wednesdays 1 PM CEST/ 4:30 PM IST virtual IFPA room: h ...@@ -103,23 +192,21 @@ The review call happen on Wednesdays 1 PM CEST/ 4:30 PM IST virtual IFPA room: h
## Action items ## Action items
- [x] Gather and organise the results. * [x] Gather and organise the results.
- [x] Generate 2 detector skymaps + QTs. * [x] Generate 2 detector skymaps + QTs.
- [x] Plot different (projected, design, O4a) PSDs and compare * [x] Plot different (projected, design, O4a) PSDs and compare
## 22 September 2023 ## 22 September 2023
* We discussed the 2 v/s 3 detector events ROCs using skymaps * We discussed the 2 v/s 3 detector events ROCs using skymaps
* We saw the PSDs, it seems O4a real and projected noise is compatible except for the lower frequency (<70 Hz). The two LIGOs are working close to the design sensitivity as well. * We saw the PSDs, it seems O4a real and projected noise is compatible except for the lower frequency (\<70 Hz). The two LIGOs are working close to the design sensitivity as well.
* We went through the first set of preliminary results of lensid for O4a events. * We went through the first set of preliminary results of lensid for O4a events.
* We also discussed lensingflow integration and the possibility of Asimov. * We also discussed lensingflow integration and the possibility of Asimov.
## Action items ## Action items
- [x] Make lensid compatible with a single pair, with the config file. * [x] Make lensid compatible with a single pair, with the config file.
- [x] FAP computation implemented * [x] FAP computation implemented
## 10 October 2023 ## 10 October 2023
...@@ -128,21 +215,19 @@ The review call happen on Wednesdays 1 PM CEST/ 4:30 PM IST virtual IFPA room: h ...@@ -128,21 +215,19 @@ The review call happen on Wednesdays 1 PM CEST/ 4:30 PM IST virtual IFPA room: h
* We saw a couple of pairs that seem significant with LensID preliminary results. Some of them have bad skymap. needs fixing. * We saw a couple of pairs that seem significant with LensID preliminary results. Some of them have bad skymap. needs fixing.
* We also discussed about the real noise injections, think it might be good to start working towards it. * We also discussed about the real noise injections, think it might be good to start working towards it.
## Action items ## Action items
- [x] Start working on automation and CBCFlow integration. * [x] Start working on automation and CBCFlow integration.
## 8 November 2023 ## 8 November 2023
* We discussed the integration of lensid with the lensing flow and visited the new package : https://git.ligo.org/srashti.goyal/alensidforlensingflow * We discussed the integration of lensid with the lensing flow and visited the new package : https://git.ligo.org/srashti.goyal/alensidforlensingflow
* JR suggested to use O4a real noise PSDs for the training and testing of the final ML model for the production runs. (detchar)[https://ldas-jobs.ligo-wa.caltech.edu/~detchar/summary/day/20231108/] * JR suggested to use O4a real noise PSDs for the training and testing of the final ML model for the production runs. (detchar)\[https://ldas-jobs.ligo-wa.caltech.edu/\~detchar/summary/day/20231108/\]
* We are still unsure about the inclusion of the population and the time delay lensing priors for the follow-up strategy. * We are still unsure about the inclusion of the population and the time delay lensing priors for the follow-up strategy.
## Action items ## Action items
- [ ] Plot ROCs varying the SNRs, chirp masses etc. * [ ] Plot ROCs varying the SNRs, chirp masses etc.
- [ ] Update the result review page with the new scripts. * [ ] Update the result review page with the new scripts.
- [ ] Train a final ML while optimising. * [ ] Train a final ML while optimising.
- [ ] Note the changes in the reviewed code. * [ ] Note the changes in the reviewed code.
\ No newline at end of file \ No newline at end of file