Timothy Davies (156230f1) at 28 Mar 10:07
Move port-tools into share.
I've skimmed through src/spiir/cli/compare_run_directories.py
, and it looks like an improvement! Lost me a bit in the somewhat heavily indented for
loops of the cli
function, but it's all harmless enough.
Nice to have some working unit tests! LGTM, once the other branches are merged and src/spiir/cli/compare_run_directories.py
is the only change.
I've mostly skimmed for this review, seeing as I've been through it before.
Still needs to:
Pathlike
-> Union[str, Pathlike]
, andfar_contour_plot
shouldn't count ifos == 2
as a single detector event.So a couple of things to check, but otherwise I'm happy with the changes.
Let me know when you're happy and I'll do a last check, and then merge.
Started review in a call. This one's low priority and we're unsure if it will be better or worse than the current version.
I'll give it a test in some weeks and see if it's a nicer workflow or not before merging.
Reviewed in call and approved, pending some test results & it should throw an error when trying to run in Py2 on CIT, with or without Singularity.
Add ozstar submission for new-run.sh Add conda option for bash_helper_functions.
Also pending passing tests.
Reviewed in call. The zerolags test could be removed in a separate MR, but we're reviewing that shortly so either way works.
Happy to approve.
Timothy Davies (552c16c5) at 28 Mar 08:19
Fix gitlab ci pipeline by excluding share, and move py2 files there.
This MR add scripts to highlight incompatible gstreamer 0.10 code (from gstlal).
These were considered during the upgrade, and could be useful in future, but it would be harmless to remove them.
This repeats all changes from !226 for these files.
I intend to split !226's changes into a number of MRs, which won't be functional code versions themselves, but once complete will encompass the full set of changes to upgrade to py3.
This should provide useful code diffs for reviewers.
Timothy Davies (68d3c736) at 27 Mar 09:46
Add gst upgrade scripts.
This MR updates various unused files to be compatible with Python 3 and Gstreamer 1.0.
All affected files have been unused for a long period of time, but the changes are simple enough that it was harmless to do.
However, if they become difficult to review, we can delete them instead.
This repeats all changes from !226 for these files.
I intend to split !226's changes into a number of MRs, which won't be functional code versions themselves, but once complete will encompass the full set of changes to upgrade to py3.
This should provide useful code diffs for reviewers.
Timothy Davies (ab683580) at 27 Mar 09:39
Update unused script files to gstreamer 1.0 caps.
... and 1 more commit
Timothy Davies (a1eacd74) at 27 Mar 09:01
Merge branch 'gstreamer_python_upgrade' into tdv-use-original-resam...
... and 4 more commits
Timothy Davies (7f1c7f54) at 27 Mar 08:49
This is a required change to run with the latest version of GstLAL here: spiir-group/gstlal!11
We'd made this fix on the test branch for Py2 comparisons tdv-use-original-resampler
, but not the main one.
Timothy Davies (794a74f6) at 27 Mar 08:49
Merge branch 'tdv-use-O4b-gstlal' into 'gstreamer_python_upgrade'
... and 1 more commit
This is a required change to run with the latest version of GstLAL here: spiir-group/gstlal!11
We'd made this fix on the test branch for Py2 comparisons tdv-use-original-resampler
, but not the main one.